Repository navigation
[PWGCF] correlations.cxx: prompt + non-prompt separation - #18432
Merged
Merged
Conversation
jaelpark
commented
Oct 23, 2026
Collaborator
- MC prompt + non-prompt separation
- duplicates workaround for old derived datasets without proper 2-prong masks
- local multiplicity weight loader
- signal/reflection fixes
jaelpark
requested review from
alibuild,
dsarkaralice,
jgrosseo,
lauraser and
victor-gonzalez
as code owners
October 23, 2026 10:58
|
O2 linter results: ❌ 0 errors, |
Collaborator
|
Error while checking build/O2Physics/code-check for 5221251 at 2026-10-23 14:08: Full log here. |
jgrosseo
reviewed
Oct 25, 2026
Comment on lines
+659
to
+660
| static std::set<std::tuple<int, int>> duplicates; // workaround for old derived datasets involving 2prongs when cfgDecayParticleMask = 0 | ||
| duplicates.clear(); |
Contributor
There was a problem hiding this comment.
This will be executed always, is it better to check one of the configs as below?
Collaborator
Author
There was a problem hiding this comment.
I could add if here to check the config. Maybe the if overhead is less than an empty clear op. Anyways I would remove these lines and the duplicate check below later when I finally rerun my HF datasets.
jgrosseo
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.