Skip to content

[PWGLF] Add more QA hist in hStrangeCorrelation.cxx - #18444

Merged
romainschotter merged 2 commits into
AliceO2Group:masterfrom
kcui1:AddQAhistForFailureTriggers
Oct 23, 2026
Merged

romainschotter merged 2 commits into
AliceO2Group:masterfrom
kcui1:AddQAhistForFailureTriggers

Conversation

@kcui1

@kcui1 kcui1 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 19 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Add more QA hist in hStrangeCorrelation.cxx [PWGLF] Add more QA hist in hStrangeCorrelation.cxx Oct 23, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 6b4a024 at 2026-10-23 16:45:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3063:110: error: arithmetic between enumeration type 'HStrangeCorrelation::PairLossTriggerMatchQABin' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 6b4a024 at 2026-10-23 16:47:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3063:110: error: arithmetic between enumeration type 'HStrangeCorrelation::PairLossTriggerMatchQABin' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 6b4a024 at 2026-10-23 17:02:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 1 warnings.'
Found 1 errors and 1 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/745e17e725fa8b70227cec2fe12558ac6ba9c32e/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3063:110: error: arithmetic between enumeration type 'HStrangeCorrelation::PairLossTriggerMatchQABin' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/745e17e725fa8b70227cec2fe12558ac6ba9c32e/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:1359:45: warning: casting (double + 0.5) to integer leads to incorrect rounding; consider using lround (#include <cmath>) instead [bugprone-incorrect-roundings]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@romainschotter
romainschotter merged commit 8b3d0e0 into AliceO2Group:master Oct 23, 2026
14 checks passed
@kcui1
kcui1 deleted the AddQAhistForFailureTriggers branch October 25, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants