[PWGCF] radialFlowDecorr: Edits for QM Prep-->all systematic variations in one wagon by somabhatta · Pull Request #18449 · AliceO2Group/O2Physics

somabhatta · 2026-10-23T21:33:20Z

Changes ensure all cuts are according to suggestions in ALICEdocs, all systematic variations run together alongwith default in radial flow decorrelation analysis.

…ns in one wagon

github-actions · 2026-10-23T21:33:38Z

O2 linter results: ❌ 0 errors, ⚠️ 13 warnings, 🔕 0 disabled

alibuild · 2026-10-23T21:35:27Z

Error while checking build/O2Physics/staging for a06f2b0 at 2026-10-23 23:35:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:498:45: error: arithmetic between enumeration type 'RadialFlowDecorr::EFwdDet' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1607:118: error: arithmetic between enumeration type 'RadialFlowDecorr::EEvtCut' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1607:148: error: arithmetic between enumeration type 'RadialFlowDecorr::ESystType' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1611:120: error: arithmetic between enumeration type 'RadialFlowDecorr::ETrkCut' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1611:150: error: arithmetic between enumeration type 'RadialFlowDecorr::ESystType' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1637:157: error: arithmetic between enumeration type 'RadialFlowDecorr::EEvtCut' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1639:159: error: arithmetic between enumeration type 'RadialFlowDecorr::ETrkCut' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1715:220: error: arithmetic between enumeration type 'RadialFlowDecorr::EChanQA' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1728:173: error: arithmetic between enumeration type 'RadialFlowDecorr::EEffCat' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1740:183: error: arithmetic between enumeration type 'RadialFlowDecorr::ETrackOrigin' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1750:163: error: arithmetic between enumeration type 'RadialFlowDecorr::EVtxQA' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1763:138: error: arithmetic between enumeration type 'RadialFlowDecorr::EFlatType' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1781:181: error: arithmetic between enumeration type 'RadialFlowDecorr::EMeanObs' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1797:162: error: arithmetic between enumeration type 'RadialFlowDecorr::EFlucObs' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-10-23T21:37:00Z

Error while checking build/O2Physics/o2 for a06f2b0 at 2026-10-23 23:36:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:498:45: error: arithmetic between enumeration type 'RadialFlowDecorr::EFwdDet' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1607:118: error: arithmetic between enumeration type 'RadialFlowDecorr::EEvtCut' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1607:148: error: arithmetic between enumeration type 'RadialFlowDecorr::ESystType' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1611:120: error: arithmetic between enumeration type 'RadialFlowDecorr::ETrkCut' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1611:150: error: arithmetic between enumeration type 'RadialFlowDecorr::ESystType' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1637:157: error: arithmetic between enumeration type 'RadialFlowDecorr::EEvtCut' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1639:159: error: arithmetic between enumeration type 'RadialFlowDecorr::ETrkCut' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1715:220: error: arithmetic between enumeration type 'RadialFlowDecorr::EChanQA' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1728:173: error: arithmetic between enumeration type 'RadialFlowDecorr::EEffCat' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1740:183: error: arithmetic between enumeration type 'RadialFlowDecorr::ETrackOrigin' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1750:163: error: arithmetic between enumeration type 'RadialFlowDecorr::EVtxQA' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1763:138: error: arithmetic between enumeration type 'RadialFlowDecorr::EFlatType' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1781:181: error: arithmetic between enumeration type 'RadialFlowDecorr::EMeanObs' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1797:162: error: arithmetic between enumeration type 'RadialFlowDecorr::EFlucObs' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-10-23T21:43:57Z

Error while checking build/O2Physics/code-check for a06f2b0 at 2026-10-23 23:43:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 14 errors and 40 warnings.'
Found 14 errors and 40 warnings.
++ [[ 14 -gt 0 ]]
++ cat /sw/BUILD/72cc60a8ab3553aaae1c9eb6f52bde582bd6b066/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:498:45: error: arithmetic between enumeration type 'RadialFlowDecorr::EFwdDet' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1607:118: error: arithmetic between enumeration type 'RadialFlowDecorr::EEvtCut' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1607:148: error: arithmetic between enumeration type 'RadialFlowDecorr::ESystType' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1611:120: error: arithmetic between enumeration type 'RadialFlowDecorr::ETrkCut' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1611:150: error: arithmetic between enumeration type 'RadialFlowDecorr::ESystType' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1637:157: error: arithmetic between enumeration type 'RadialFlowDecorr::EEvtCut' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1639:159: error: arithmetic between enumeration type 'RadialFlowDecorr::ETrkCut' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1715:220: error: arithmetic between enumeration type 'RadialFlowDecorr::EChanQA' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1728:173: error: arithmetic between enumeration type 'RadialFlowDecorr::EEffCat' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1740:183: error: arithmetic between enumeration type 'RadialFlowDecorr::ETrackOrigin' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1750:163: error: arithmetic between enumeration type 'RadialFlowDecorr::EVtxQA' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1763:138: error: arithmetic between enumeration type 'RadialFlowDecorr::EFlatType' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1781:181: error: arithmetic between enumeration type 'RadialFlowDecorr::EMeanObs' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:1797:162: error: arithmetic between enumeration type 'RadialFlowDecorr::EFlucObs' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
++ [[ 40 -gt 0 ]]
++ cat /sw/BUILD/72cc60a8ab3553aaae1c9eb6f52bde582bd6b066/O2Physics-code-check/warnings.txt
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:683:53: warning: implicit conversion 'unsigned int' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:825:34: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:2053:21: warning: redundant explicit casting to the same type 'TH3 *' as the sub-expression, remove this casting [readability-redundant-casting]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:2054:34: warning: redundant explicit casting to the same type 'TH3 *' as the sub-expression, remove this casting [readability-redundant-casting]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:2541:12: warning: implicit conversion 'uint32_t' (aka 'unsigned int') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:2583:14: warning: implicit conversion 'uint32_t' (aka 'unsigned int') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:2631:12: warning: implicit conversion 'uint32_t' (aka 'unsigned int') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:2654:14: warning: implicit conversion 'uint32_t' (aka 'unsigned int') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:2670:15: warning: variable 'eff' is not initialized [cppcoreguidelines-init-variables]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:2670:20: warning: variable 'fake' is not initialized [cppcoreguidelines-init-variables]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:2670:26: warning: variable 'flatWeight' is not initialized [cppcoreguidelines-init-variables]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:2698:12: warning: implicit conversion 'uint32_t' (aka 'unsigned int') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:2756:14: warning: implicit conversion 'uint32_t' (aka 'unsigned int') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:2783:15: warning: variable 'eff' is not initialized [cppcoreguidelines-init-variables]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:2783:20: warning: variable 'fake' is not initialized [cppcoreguidelines-init-variables]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:2783:26: warning: variable 'flatWeight' is not initialized [cppcoreguidelines-init-variables]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:2785:14: warning: implicit conversion 'uint32_t' (aka 'unsigned int') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:2865:12: warning: implicit conversion 'uint32_t' (aka 'unsigned int') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:2923:14: warning: implicit conversion 'uint32_t' (aka 'unsigned int') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/EbyEFluctuations/Tasks/radialFlowDecorr.cxx:2950:15: warning: variable 'eff' is not initialized [cppcoreguidelines-init-variables]
[0 more errors; see full log]

Full log here.

…pcheck const pointer

…k, PWGCF-standard track/event cuts, clang-tidy fixes

[PWGCF] radialFlowDecorr: Edits for QM Prep-->all systematic variatio…

a06f2b0

…ns in one wagon

somabhatta requested review from SwatiSaha-1997, alibuild, dsarkaralice, fsii, isputows, lauraser and victor-gonzalez as code owners October 23, 2026 21:33

github-actions Bot added the pwgcf label Oct 23, 2026

somabhatta marked this pull request as draft October 23, 2026 21:41

somabhatta added 2 commits October 24, 2026 01:12

[PWGCF] radialFlowDecorr: fix GCC enum-float arithmetic errors and cp…

8f831fb

…pcheck const pointer

[PWGCF] radialFlowDecorr: TH3 efficiency maps in centrality, no mcMas…

066d539

…k, PWGCF-standard track/event cuts, clang-tidy fixes

somabhatta marked this pull request as ready for review October 24, 2026 08:47

fsii approved these changes Oct 24, 2026

View reviewed changes

fsii merged commit 54da334 into AliceO2Group:master Oct 24, 2026
14 checks passed

Navigation Menu

Repository navigation

[PWGCF] radialFlowDecorr: Edits for QM Prep-->all systematic variations in one wagon - #18449

[PWGCF] radialFlowDecorr: Edits for QM Prep-->all systematic variations in one wagon#18449
fsii merged 3 commits into
AliceO2Group:masterfrom
somabhatta:radial-flow-decorr-allvar

somabhatta commented Oct 23, 2026

Uh oh!

github-actions Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

alibuild commented Oct 23, 2026

Uh oh!

alibuild commented Oct 23, 2026

Uh oh!

alibuild commented Oct 23, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

somabhatta commented Oct 23, 2026

Uh oh!

github-actions Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Oct 23, 2026

Uh oh!

alibuild commented Oct 23, 2026

Uh oh!

alibuild commented Oct 23, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Oct 23, 2026 •

edited

Loading