[PWGCF] Add Time Associate method by huinaibing · Pull Request #18457 · AliceO2Group/O2Physics

huinaibing · 2026-10-25T13:04:24Z

New method used for track-collision association

github-actions · 2026-10-25T13:04:41Z

O2 linter results: ❌ 0 errors, ⚠️ 23 warnings, 🔕 0 disabled

alibuild · 2026-10-25T13:07:13Z

Error while checking build/O2Physics/code-check for cb8418a at 2026-10-25 14:07:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:280:26: error: 'getTaskOptionValue' was not declared in this scope; did you mean 'o2::common::core::getTaskOptionValue'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:280:26: error: 'getTaskOptionValue' was not declared in this scope; did you mean 'o2::common::core::getTaskOptionValue'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:280:26: error: 'getTaskOptionValue' was not declared in this scope; did you mean 'o2::common::core::getTaskOptionValue'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:280:26: error: 'getTaskOptionValue' was not declared in this scope; did you mean 'o2::common::core::getTaskOptionValue'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:280:26: error: 'getTaskOptionValue' was not declared in this scope; did you mean 'o2::common::core::getTaskOptionValue'?
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-10-25T13:16:55Z

Error while checking build/O2Physics/o2 for cb8418a at 2026-10-25 14:16:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:280:26: error: 'getTaskOptionValue' was not declared in this scope; did you mean 'o2::common::core::getTaskOptionValue'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:280:26: error: 'getTaskOptionValue' was not declared in this scope; did you mean 'o2::common::core::getTaskOptionValue'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:280:26: error: 'getTaskOptionValue' was not declared in this scope; did you mean 'o2::common::core::getTaskOptionValue'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:280:26: error: 'getTaskOptionValue' was not declared in this scope; did you mean 'o2::common::core::getTaskOptionValue'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:280:26: error: 'getTaskOptionValue' was not declared in this scope; did you mean 'o2::common::core::getTaskOptionValue'?
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-10-25T13:16:57Z

Error while checking build/O2Physics/staging for cb8418a at 2026-10-25 14:16:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:280:26: error: 'getTaskOptionValue' was not declared in this scope; did you mean 'o2::common::core::getTaskOptionValue'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:280:26: error: 'getTaskOptionValue' was not declared in this scope; did you mean 'o2::common::core::getTaskOptionValue'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:280:26: error: 'getTaskOptionValue' was not declared in this scope; did you mean 'o2::common::core::getTaskOptionValue'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:280:26: error: 'getTaskOptionValue' was not declared in this scope; did you mean 'o2::common::core::getTaskOptionValue'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:280:26: error: 'getTaskOptionValue' was not declared in this scope; did you mean 'o2::common::core::getTaskOptionValue'?
ninja: build stopped: subcommand failed.

Full log here.

Please consider the following formatting changes to AliceO2Group#18457

alibuild · 2026-10-25T13:48:39Z

Error while checking build/O2Physics/code-check for 219e1ae at 2026-10-25 14:48:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 3 errors and 25 warnings.'
Found 3 errors and 25 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/bc5e786464d8a6477995fc894124b2ff6fac40b8/O2Physics-code-check/errors.txt
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:358:70: error: no header providing "o2::aod::track::TrackTypeEnum" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:525:27: error: no header providing "TESTBIT" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:525:62: error: no header providing "o2::aod::track::TrackTimeResIsRange" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 25 -gt 0 ]]
++ cat /sw/BUILD/bc5e786464d8a6477995fc894124b2ff6fac40b8/O2Physics-code-check/warnings.txt
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:270:3: warning: function 'pt' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:271:3: warning: function 'eta' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:272:3: warning: function 'phi' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:273:3: warning: function 'dcaXY' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:274:3: warning: function 'dcaZ' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:366:11: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:367:11: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:368:11: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:369:11: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:374:211: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:375:45: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:375:183: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:380:64: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:381:65: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:938:3: warning: initial values in enum 'PidFlowPtCorr::PidResponseBin' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:1071:17: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:1072:49: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:1126:17: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:1127:41: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:3674:33: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:3695:40: warning: implicit conversion 'unwrap_t<unsigned char>' (aka 'unsigned char') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:3711:25: warning: use 'contains' to check for membership [readability-container-contains]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:3719:25: warning: use 'contains' to check for membership [readability-container-contains]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:3719:68: warning: use 'contains' to check for membership [readability-container-contains]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:3951:45: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
++ [[ 3 -gt 0 ]]
++ exit 1
--

Full log here.

Please consider the following formatting changes to AliceO2Group#18457

alibuild · 2026-10-25T14:30:50Z

Error while checking build/O2Physics/code-check for d27f63e at 2026-10-25 15:30:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 3 errors and 25 warnings.'
Found 3 errors and 25 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/662d81d2731ed3ce69b465429adf238803045628/O2Physics-code-check/errors.txt
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:358:70: error: no header providing "o2::aod::track::TrackTypeEnum" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:525:27: error: no header providing "TESTBIT" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:525:62: error: no header providing "o2::aod::track::TrackTimeResIsRange" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 25 -gt 0 ]]
++ cat /sw/BUILD/662d81d2731ed3ce69b465429adf238803045628/O2Physics-code-check/warnings.txt
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:270:3: warning: function 'pt' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:271:3: warning: function 'eta' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:272:3: warning: function 'phi' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:273:3: warning: function 'dcaXY' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:274:3: warning: function 'dcaZ' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:366:11: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:367:11: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:368:11: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:369:11: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:374:211: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:375:45: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:375:183: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:380:64: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:381:65: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:938:3: warning: initial values in enum 'PidFlowPtCorr::PidResponseBin' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:1071:17: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:1072:49: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:1126:17: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:1127:41: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:3674:33: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:3695:40: warning: implicit conversion 'unwrap_t<unsigned char>' (aka 'unsigned char') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:3711:25: warning: use 'contains' to check for membership [readability-container-contains]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:3719:25: warning: use 'contains' to check for membership [readability-container-contains]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:3719:68: warning: use 'contains' to check for membership [readability-container-contains]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:3951:45: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
++ [[ 3 -gt 0 ]]
++ exit 1
--

Full log here.

[PWGCF] Add Time Associate method

cb8418a

huinaibing requested review from EmilGorm, alibuild, dsarkaralice, jaelpark, lauraser, majanik, victor-gonzalez and wenyaCern as code owners October 25, 2026 13:04

github-actions Bot added the pwgcf label Oct 25, 2026

alibuild mentioned this pull request Oct 25, 2026

Please consider the following formatting changes to #18457 huinaibing/O2Physics#10

Merged

wenyaCern previously approved these changes Oct 25, 2026

View reviewed changes

fix a bug

219e1ae

huinaibing dismissed wenyaCern’s stale review via 219e1ae October 25, 2026 13:17

alibuild and others added 2 commits October 25, 2026 13:18

Please consider the following formatting changes

0b37e8b

Merge pull request #10 from alibuild/alibot-cleanup-18457

d27f63e

Please consider the following formatting changes to AliceO2Group#18457

wenyaCern previously approved these changes Oct 25, 2026

View reviewed changes

wenyaCern enabled auto-merge (squash) October 25, 2026 13:30

fix issues

da4c102

auto-merge was automatically disabled October 25, 2026 14:20
Head branch was pushed to by a user without write access

huinaibing dismissed wenyaCern’s stale review via da4c102 October 25, 2026 14:20

Please consider the following formatting changes

26a8b8a

alibuild mentioned this pull request Oct 25, 2026

Please consider the following formatting changes to #18457 huinaibing/O2Physics#11

Merged

Merge pull request #11 from alibuild/alibot-cleanup-18457

4b968fa

Please consider the following formatting changes to AliceO2Group#18457

wenyaCern approved these changes Oct 25, 2026

View reviewed changes

wenyaCern enabled auto-merge (squash) October 25, 2026 14:57

wenyaCern merged commit 9410f19 into AliceO2Group:master Oct 25, 2026
15 checks passed

Navigation Menu

Repository navigation

[PWGCF] Add Time Associate method - #18457

[PWGCF] Add Time Associate method#18457
wenyaCern merged 7 commits into
AliceO2Group:masterfrom
huinaibing:master

huinaibing commented Oct 25, 2026

Uh oh!

github-actions Bot commented Oct 25, 2026

Uh oh!

alibuild commented Oct 25, 2026

Uh oh!

alibuild commented Oct 25, 2026

Uh oh!

alibuild commented Oct 25, 2026

Uh oh!

alibuild commented Oct 25, 2026

Uh oh!

alibuild commented Oct 25, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

huinaibing commented Oct 25, 2026

Uh oh!

github-actions Bot commented Oct 25, 2026

Uh oh!

alibuild commented Oct 25, 2026

Uh oh!

alibuild commented Oct 25, 2026

Uh oh!

alibuild commented Oct 25, 2026

Uh oh!

alibuild commented Oct 25, 2026

Uh oh!

alibuild commented Oct 25, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

3 participants