Repository navigation
Stable 26.3 Backport of #131963 - Clear --jwt and the other credential options from the command line of clickhouse-client and clickhouse-keeper-client - #2931
Conversation
…ptions-from-command-line Clear `--jwt` and the other credential options from the command line of `clickhouse-client` and `clickhouse-keeper-client`
CI triage for 9b67254Summary: 3 distinct problems. 1 is caused by this PR, 1 is infra, and 1 is the DCO process check.
1.
|
|
@blau-ai fix fails caused by this PR here |
…mand_line clickhouse-client of 26.3 has no --oauth-client-secret option, so it exited with UNRECOGNIZED_ARGUMENTS before the test could inspect /proc/<pid>/cmdline. clearPasswordFromCommandLine still lists the option, which is harmless. Signed-off-by: blau-ai <blau-ai@users.noreply.github.com>
|
Fixed in 7254e52 (pushed to Failure this PR caused
Failures not caused by this PR
CI on the new head still has to confirm the fix. My local run was a single run against the debug CI binary, without sanitizers. |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
clickhouse-clientnow clears the values of--jwt,--ssh-key-passphrase,--one-time-passwordand--oauth-client-secretfrom its command line, as it already did for--password, so they are no longer visible inpsand/proc/<pid>/cmdline.clickhouse-keeper-clientnow does the same for--passwordand--identity. Closes ClickHouse#131191. (ClickHouse#131963 by @groeneai)Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: