Repository navigation
The ldh plugin ships no hook: the skills pass its settings to ldh - #536
Open
namedgraph wants to merge 1 commit into
Open
namedgraph wants to merge 1 commit into
namedgraph wants to merge 1 commit into
Conversation
The plugin directory refuses command hooks and shell scripts from organizations that are not verified, so hooks/hooks.json and hooks/ldh-env.sh go. Nothing else a plugin ships reaches the environment of Bash commands, so the skills now start each ldh command with an export of the base and certificate path, substituted from userConfig into the skill text. A sensitive value is not substituted there, so the certificate's password is no longer a plugin setting: ldh reads LDH_CERT_PASSWORD from the user's own environment. cert_file becomes a string, whose substitution is documented, where a file option's is not. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin directory refuses this version of the
ldhplugin. It accepts command hooks and script files only from verified organizations, and #521 added both: aSessionStartcommand hook (hooks/hooks.json) and the shell script it runs (hooks/ldh-env.sh). The hook exported the plugin's settings asLDH_BASE,LDH_CERT_FILEandLDH_CERT_PASSWORDfor theldhCLI.What changes
hooks/is removed. The plugin now ships only Markdown, JSON and its icon.ldhwithexport LDH_BASE='${user_config.ldh_base}' LDH_CERT_FILE='${user_config.cert_file}';. Claude Code substitutes a non-sensitive userConfig value into skill text, and nothing else a plugin ships reaches the environment of Bash commands.ldhwithout a hook.ldhalready readsLDH_CERT_PASSWORD; the user sets it in their own environment, for example theenvblock of~/.claude/settings.json. The skills still forbid readingsecrets/, searching the disk for credentials, or guessing.cert_fileis astring, a path. Substitution of afileoption is not documented; a string's is.Directory findings
hooks/.LDH_CERT_PASSWORD. It is a warning, and the plugin has no other way to get the password toldh. The PEM the container generates has an encrypted key, so it needs one too.documentationUrl,supportUrl,termsOfServiceUrlandprivacyPolicyUrlare listing fields that only the directory reads, which the warning itself exempts. They stay.Checks
claude plugin validate plugins/ldhpasses, with its directory checks reporting nothing. The plugin has no CI test of its own; the skill text is the change.🤖 Generated with Claude Code