Repository navigation
fix(web): fetch the Optimizely datafile as JSON instead of a script - #14790
Open
dylanjeffers wants to merge 1 commit into
Open
dylanjeffers wants to merge 1 commit into
dylanjeffers wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
index.htmlloaded the Optimizely datafile through a<script src=".../<key>.json/tag.js">tag, so whatever that host returned ran on audius.co. This fetches the same datafile as JSON instead, so nothing from the datafile host is executed.index.html: inlinefetchofexperiments.audius.co/datafiles/<key>.json, kept in the head so it still starts alongside the entry bundle. Resolves to{}on any failure, same as the oldonError.remote-config-instance.ts: awaitswindow.optimizelyDatafilePromiseand drops theOPTIMIZELY_LOADEDevent.preconnectfor the datafile host is nowcrossorigin, since the request is CORS.Context: the Nov 16 Optimizely Web Experimentation compromise served malicious JS from Optimizely's CDN. We were not affected (the file we load is a plain datafile assignment and predates the attack), but there is no reason to execute it.
Testing
access-control-allow-origin: *.tsconpackages/webshows no errors in the touched files.weekly_rotationon) and the network tab shows the.jsonfetch.🤖 Generated with Claude Code