Repository navigation
Deploy the demo site from master - #561
Merged
Merged
Conversation
Bring the homepage, its stylesheet and its theme loader over from the gh-pages branch (8bf9b5c), re-indented to 2 spaces and otherwise unchanged (`git diff -w` against gh-pages is empty), so the site can be deployed from master. Not copied: the docs page and its assets (the README is the documentation), the old `color` library build (the repo's scripts/color.mjs replaces it) and Modernizr (no longer needed). The next commits update the page accordingly.
- Point the getting-started snippet at pace-js@1 instead of @latest. - Load the repo's own color code (scripts/color.mjs, copied in at deploy time) instead of an old build of the `color` library, and compile the previews with the picker's color, so each preview and download matches the committed theme files. - Add the material theme to the theme list. - Render the previews in standards mode (they had no doctype). - Allow zooming, update jQuery to 3.7.1, link the Documentation button to the README, and stop the browser from requesting a missing favicon. - Save downloads with a local helper instead of patching `console`. - Remove code for old Internet Explorer and Chrome Frame, Modernizr, the theme loader's unused Node.js branch and a 3D-acceleration hack. - Fix small bugs: an accidental global, a stray </h4>, an end tag on <input>, deprecated jQuery bind/unbind, the page replacing pace's own <body> classes, and the color button's label sitting off-center. - Replace "Submit a theme" with a link to the repo.
The docs page on the site was an old copy of the README. Replace it with a redirect to the README, keeping links to its sections (#events, ...) working.
Deploy site/ to GitHub Pages from master with GitHub's Pages actions, through the github-pages environment. The site gets the repo's pace.min.js, theme templates and color code at deploy time, so it always shows the current version. It runs when those files change, or by hand. Its actions are pinned in actions.lock.
- Keep a downloaded theme's object URL for a minute instead of releasing it right after the click, which can make the download fail in Safari. - Ignore download clicks until the theme's preview has been compiled, instead of saving a file containing "undefined". - Give the deploy job more time than deploy-pages' own 10-minute timeout. - End the site's HTML and CSS files with a newline, per .editorconfig.
The docs page now redirects to the README, so the link only led back to the page it was on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the demo site (codebyzach.github.io/pace) from the
gh-pagesbranch intosite/and deploys it with GitHub Actions.gh-pages, re-indented to 2 spaces (git diff -wagainstgh-pagesis empty).pace-js@1; previews and downloads are compiled with the repo's own color code and the picker's color, so they match the committed theme files; the material theme is listed; previews render in standards mode; zoom is allowed; jQuery 3.7.1; old Internet Explorer code removed; several small bugs fixed (listed in the commit). The page's own progress bar also gets its color back: the old site loaded an uncompiled template for it.Deploy siteworkflow (GitHub's Pages actions,github-pagesenvironment, pinned inactions.lock). At deploy time it copies in the repo'space.min.js, theme templates and color code.How to verify: assemble the site the way the workflow does, serve it at
/pace/, and open it. All 15 previews match the committedthemes/blue/files (andthemes/red/after picking that color), downloads match the committed files, the color picker works, and the console is clean.After merging: the workflow deploys from
master(allowed because thegithub-pagesenvironment only acceptsmaster). Then switch the Pages source to "GitHub Actions", run the workflow once by hand, and retiregh-pagesonce the new site is confirmed live.