Repository navigation
DataTableOverview: .NET 10 and the article's order - #2322
Open
vladimir-pecanac-main wants to merge 1 commit into
Open
vladimir-pecanac-main wants to merge 1 commit into
vladimir-pecanac-main wants to merge 1 commit into
Conversation
…rint and typed-query helpers Both projects target net10.0 and the test packages move to xunit 2.9.3, xunit.runner.visualstudio 4.0.1, Microsoft.NET.Test.Sdk 18.11.0 and coverlet.collector 10.1.0. Program.cs adds the row before the primary key, as the article does, and gains AddPrimaryKey, AddNewRowFromValues, PrintTable and GetTickersBelow. The second carrot row in the CSV gets the right Sales value, ReadFields() results are null-checked, and seven tests cover the new code and the two failure cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the DataTable sample to net10.0 with current xUnit 2 test packages, reorders Program.cs so the row is added before the primary key as the article now shows, adds the PrintTable, GetTickersBelow, AddPrimaryKey and AddNewRowFromValues helpers, fixes the second carrot row in the CSV, null-checks the TextFieldParser reads, and adds tests for the new helpers, the primary key on empty cells, the duplicate key and the numeric filter on string CSV columns.