Repository navigation
How to Convert Int to String in C#: .NET 10, BenchmarkDotNet, culture tests - #2325
Open
vladimir-pecanac-main wants to merge 1 commit into
Conversation
…tests Retarget both projects to net10.0, update MSTest to 4.5.1 and the test SDK and coverlet to current releases, replace the Stopwatch benchmark (whose ConvertToString case measured ToString) with a BenchmarkDotNet class run through BenchmarkSwitcher, and add two tests for the negative sign under sv-SE and the invariant culture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves strings-csharp/ConvertInt2String to net10.0 with MSTest 4.5.1, replaces the hand-rolled Stopwatch benchmark (its ConvertToString case called ToString) with a BenchmarkDotNet class that measures all eight conversions for 3 and 1,234,567 with allocations and takes command-line arguments through BenchmarkSwitcher, adds the four culture lines the article prints to Program.cs, and adds two tests showing that sv-SE formats a negative int with the Unicode minus sign while the invariant culture uses the hyphen.