Repository navigation
Merging dictionaries in C#: port to .NET 10, duplicate-key tests - #2327
Open
vladimir-pecanac-main wants to merge 1 commit into
Open
vladimir-pecanac-main wants to merge 1 commit into
vladimir-pecanac-main wants to merge 1 commit into
Conversation
… with tests Retarget all three projects to net10.0, update NUnit, the test SDK, coverlet and BenchmarkDotNet, add the notnull key constraint to the six merge methods, initialise the benchmark dictionaries where they are declared, pass args to BenchmarkRunner, move the tests to the constraint model, fix the Duplicate spelling in test names and add four tests for duplicate keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports collections-csharp/MergingDictionariesInCSharp to net10.0 with NUnit 5.0.0, Microsoft.NET.Test.Sdk 18.11.0, coverlet.collector 10.1.0 and BenchmarkDotNet 0.15.8, adds the notnull key constraint to the six merge methods, initialises the benchmark dictionaries at declaration, passes args to BenchmarkRunner so command-line options reach BenchmarkDotNet, moves the tests to the NUnit constraint model, fixes the Duplicate spelling in three test names and adds four tests that pin what each method does with a duplicate key.