Repository navigation
RetrieveJSONProperty: .NET 10, NUnit 5 constraint model, JsonTypeInfo name lookup - #2332
Merged
vladimir-pecanac-main merged 1 commit intoOct 26, 2026
Conversation
…JsonTypeInfo name lookup Retarget both projects to net10.0, update Newtonsoft.Json to 13.0.4 and the test packages to NUnit 5.0.0, NUnit3TestAdapter 6.3.1, NUnit.Analyzers 4.15.0, Microsoft.NET.Test.Sdk 18.11.0 and coverlet.collector 10.1.0. Move the tests to Assert.That. Deserialize to Dictionary<string, object?> in the serialization round trip so non-string values work. Add GetSerializedPropertyNames<T>, the Customer DTO, menu option 5 and seven tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the json-csharp/RetrieveJSONProperty sample to net10.0 with Newtonsoft.Json 13.0.4 and NUnit 5.0.0, rewrites the tests with Assert.That, fixes the serialization round trip to deserialize into Dictionary<string, object?> so non-string values no longer throw, and adds GetSerializedPropertyNames, which reads the JSON names from the System.Text.Json contract (JsonTypeInfo), together with a Customer DTO, a fifth menu option and seven new tests.