Repository navigation
fix: keep toggle switches clear of the settings scrollbar - #56
Merged
Merged
Conversation
ToggleSwitch drew its track 1 px from the right edge, so the focus ring and antialiased edge were clipped against the scrollbar. Inset the track by _EDGE_PAD (4 px), shrink the text rect accordingly and reserve the padding in sizeHint. Closes #51 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51
Changes
ToggleSwitch: new_EDGE_PAD = 4right inset; track moved torect.right() - _EDGE_PAD - _TRACK_W, text rect shrunk by the same amount,sizeHint()widened by_EDGE_PAD. Focus ring offset named_FOCUS_RING; track geometry in_track_rect().hitButtonunchanged (whole row still clickable).ToggleSwitchEdgeTests(size hint includes padding, track + focus ring + pen insiderect(), row clickable).docs/PRODUCT-REVIEW-2026-10.md: item 5 marked fixed in code, pending manual Windows check.Verification
python -m unittest discover -s tests— OKpython -m compileall src/— OK🤖 Generated with Claude Code