Repository navigation
Stop submit at an empty branch in the middle of the stack - #68
Merged
Merged
Conversation
A branch with no commits of its own (all of it already in the branch below, e.g. after a reorder or a pop moved its work elsewhere) can't get a pull request: GitHub refuses to open one with no commits. Sitting under other branches that is a dead end, since their pull requests have nothing to stack on, and submit only found out part way through pushing. Check before anything is pushed. An empty branch without an open pull request under another branch being submitted stops the submit with the git stack reorder that moves it to the top, or the pop or modify that gets rid of it. At the top of what is submitted it is only a notice, and a dry run says either without stopping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A branch with no commits of its own (everything in it is already in the branch below, which is easy to end up with after a reorder) can't have a pull request, since GitHub won't open one with no commits. In the middle of a stack that's a dead end, because the PRs above it have nothing to stack on, and submit only found out part way through pushing.
Submit now checks before pushing anything. An empty branch without an open PR under another branch being submitted stops it, with the
git stack reorderthat moves it to the top (or the pop or modify that gets rid of it). At the top of what's submitted it's just a notice, and a dry run says either without stopping.