Skip to content

Tests: handle unavailable Windows symlink privilege - #247

Merged
ForNeVeR merged 3 commits into
ForNeVeR:mainfrom
hamdiakin:test/windows-symlink-capability
Oct 24, 2026
Merged

ForNeVeR merged 3 commits into
ForNeVeR:mainfrom
hamdiakin:test/windows-symlink-capability

Conversation

@hamdiakin

Copy link
Copy Markdown
Contributor

Closes #245.

Replaces the message and stack-trace based Windows symlink check with a reusable helper that recognizes ERROR_PRIVILEGE_NOT_HELD. A local Windows run without Developer Mode or elevation now skips the symlink test with actionable guidance, while the same condition fails on CI so coverage cannot disappear silently.

The contributor guide now documents both supported Windows setups and links to Microsoft documentation for Developer Mode and CreateSymbolicLinkW.

Verification:

  • dotnet test --configuration Release — 471 passed
  • dotnet build -p:CheckXmlDoc=true --no-incremental — 0 warnings, 0 errors
  • git diff --check

@ForNeVeR
ForNeVeR self-requested a review October 20, 2026 00:00
@ForNeVeR ForNeVeR self-assigned this Oct 20, 2026
@ForNeVeR
ForNeVeR force-pushed the test/windows-symlink-capability branch from ce1f779 to 517229d Compare October 24, 2026 22:17

@ForNeVeR ForNeVeR left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ForNeVeR
ForNeVeR merged commit 0788fd0 into ForNeVeR:main Oct 24, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows tests: symlink access requires dev mode or elevated access

2 participants