Repository navigation
ci(lint): align lint workflow with GitHub Actions best practices - #14780
Merged
Merged
Conversation
The Lint workflow is out of step with current GitHub Actions
recommendations and the checks run by the GitHub Actions workflow
scanner, so it needs a tidy-up before it can be re-enabled.
Changes to .github/workflows/lint.yml:
- Set workflow-level `permissions: {}` and grant `contents: read`
at the job level only.
- Add a `concurrency` group per PR with `cancel-in-progress` so
superseded runs are cancelled.
- Give the job a descriptive name and a 15 minute timeout.
- Set `persist-credentials: false` on actions/checkout; the lint
script only performs read-only fetches of the public repository.
- Correct the actions/checkout pin comment to the exact tag the SHA
refers to (v6.0.3).
- Pass `github.base_ref` to the lint script via an environment
variable instead of inline expression expansion.
- Remove trailing whitespace.
No functional change to what is linted. Verified with zizmor
(pedantic persona, no findings) and actionlint (clean).
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
product-auto-label
Bot
added
samples
amcolin
reviewed
Nov 9, 2026
… v7.1.0 The lint workflow pinned actions/checkout v6.0.3 and actions/setup-python v6.2.0; both have newer major releases. - actions/checkout v7.0.1 (3d3c42e): ESM migration and dependency updates; new checks only affect pull_request_target/workflow_run, which this workflow does not use. - actions/setup-python v7.1.0 (6d4fd22): ESM migration, dependency updates and removal of the unused pip-install input. Python 3.10 remains available for all ubuntu-latest images. Both remain pinned to full commit SHAs with exact version comments. zizmor (pedantic) and actionlint report no findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tidies up
.github/workflows/lint.ymlto follow current GitHub Actions best practices. No change to what is linted.permissions: {}; job-levelcontents: readonly.concurrencygroup withcancel-in-progressso superseded runs are cancelled.timeout-minutes.actions/checkouttov7.0.1andactions/setup-pythontov7.1.0(still pinned to full commit SHAs with exact version comments).actions/checkout: setpersist-credentials: false(the lint script only does read-only fetches).github.base_refto the lint script through anenvvariable.Validated with
zizmor --persona=pedantic(no findings) andactionlint(clean).Checklist
Testing
Compliance & Style
Post-Approval Actions