Repository navigation
Drop OpenCL GPU and skip queue checks with only the default device in test_sycl_queue.py - #3189
Open
antonwolfy wants to merge 2 commits into
Open
antonwolfy wants to merge 2 commits into
antonwolfy wants to merge 2 commits into
Conversation
… test_sycl_queue.py Level Zero is the GPU backend users target, so OpenCL GPU devices stay out of the tested devices, now by policy rather than as the CMPLRLLVM-55640 workaround. When the default device is the only one, inputs share the default queue and a dropped placement passes unnoticed, so those tests are skipped. Tests marked with the new `single_device` marker still run: they use a second queue on the same device or an in-order or profiling queue.
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
November 16, 2026 15:39
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/3189/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.22.0dev2=np2py314h8d9cdd5_8 ran successfully. |
Collaborator
test_left_right_args now passes only left or only right, and xp no longer spans all of x, so left and right are actually used. This covers the one-sided branch of the interpolate extension, which test_sycl_queue.py no longer reaches on a single-device host.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2149.
This PR revisits the scope of
dpnp/tests/test_sycl_queue.py:== "opencl"instead of the substring testin "opencl".device=devthen use the same cached queue as the default one.assert_sycl_queue_equalcompares device, context,is_in_orderand profiling, so a function that ignores the input placement still passes. I confirmed this with a mutant that movesdpnp.absresults to the default device:test_1in_1outpasses on L0 GPU alone and on OpenCL CPU alone, and fails only with two devices.single_devicemarker, registered inconftest.py. These are the diff-queue raise tests (test_2in_1out_diff_queue_but_equal_context,test_flat_setitem_diff_queue,test_cho_solve_diff_queue),test_randomandtest_random_state(in-order queues), and theTestToDeviceprofiling-queue tests.Local results:
GHA runners have a single OpenCL CPU device, so 712 tests are skipped there now. Jenkins GPU nodes keep L0 GPU + OpenCL CPU, so the cross-device checks still run there.