Repository navigation
avoid quadratic string concatenation in FullTextSearch.toString - #2859
Open
tanjiroK-coder wants to merge 1 commit into
Open
tanjiroK-coder wants to merge 1 commit into
tanjiroK-coder wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String +=inside the loop, so every column copies the whole list built so far. The grammar's ColumnList puts no limit on the column count, which makesStatement.toString()on a parsedSELECT * FROM t WHERE MATCH (c0,c1,...,cN) AGAINST ('x')quadratic in N, and the parser timeout does not cover deparsing.On a 1.1 MB statement (160k columns), CCJSqlParserUtil.parse takes about 0.4 s both before and after. toString drops from 6.8 s to 25 ms (548 KB: 1.85 s to 16 ms). The new test renders 200k columns under a 2 second preemptive timeout. It times out before the change and passes after.
./gradlew checkis green.