Skip to content

update for SVT sectors splitting into 3 section during track finding - #1517

Merged
baltzell merged 3 commits into
developmentfrom
iss1512
Oct 26, 2026
Merged

baltzell merged 3 commits into
developmentfrom
iss1512

Conversation

@tongtongcao

Copy link
Copy Markdown
Collaborator

According to test, the three-section division for the SVT sectors needs to be adjusted.
See the attached slide for details.
Split SVT Sectors into 3 Sections.pdf

@tongtongcao
tongtongcao requested a review from yugotra October 15, 2026 13:54
@baltzell baltzell added this to the Pass 3 milestone Oct 19, 2026
@baltzell baltzell linked an issue Oct 25, 2026 that may be closed by this pull request
@yugotra

yugotra commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

I checked the mapping against the attached run-19209 slide. The three edits add exactly the
intended overlaps: R1 sector 5 into section 1, R2 sector 11 into section 2, and R3 sector 13 into
section 3. They do not remove any existing membership, and an exhaustive check of all 42 valid
SVT region/sector combinations found no gaps or invalid duplicate section entries.

The CVT tests and all PR CI checks pass. I reran the first 10,000 events of run 19209
file with production beamSpotConst=2. Matching seeds by their exact SVT cluster signatures gives
eight PR-only and two baseline-only seeds, a net gain of six final tracks. Every PR-only seed
contains R1S5, R2S11, or R3S13, directly tying the recovery to this patch. Filtered fits increase
by five and the standard-good count by two; global residual widths and runtime are unchanged. One
old non-good track is lost, and only two of the eight PR-only tracks pass the standard-good cut, so
the recovered population has mixed quality rather than being eight uniformly good tracks.
I approve the implementation.
PR1517_REVIEW.txt

@yugotra yugotra left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the mapping against the attached run-19209 slide. The three edits add exactly the
intended overlaps: R1 sector 5 into section 1, R2 sector 11 into section 2, and R3 sector 13 into
section 3. They do not remove any existing membership, and an exhaustive check of all 42 valid
SVT region/sector combinations found no gaps or invalid duplicate section entries.

The CVT tests and all PR CI checks pass. I reran the first 10,000 events of run 19209
file with production beamSpotConst=2. Matching seeds by their exact SVT cluster signatures gives
eight PR-only and two baseline-only seeds, a net gain of six final tracks. Every PR-only seed
contains R1S5, R2S11, or R3S13, directly tying the recovery to this patch. Filtered fits increase
by five and the standard-good count by two; global residual widths and runtime are unchanged. One
old non-good track is lost, and only two of the eight PR-only tracks pass the standard-good cut, so
the recovered population has mixed quality rather than being eight uniformly good tracks.
I approve the implementation.

@baltzell

Copy link
Copy Markdown
Collaborator

Thanks Yuri! Did you notice any significant speed differences?

@baltzell
baltzell enabled auto-merge (squash) October 26, 2026 14:25
@baltzell
baltzell merged commit 49c8d85 into development Oct 26, 2026
24 checks passed
@baltzell
baltzell deleted the iss1512 branch October 26, 2026 14:38
@yugotra

yugotra commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

No speed differences, see details of the validations done for RGK and RGD runs attached as a file above:
https://github.com/user-attachments/files/33969639/PR1517_REVIEW.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue for SVT sectors splitting into 3 section during track finding

3 participants