Repository navigation
add trigger-bit writer class - #1522
Merged
Merged
Conversation
baltzell
enabled auto-merge (squash)
October 15, 2026 21:41
baltzell
force-pushed
the
para-trig-writer
branch
from
October 15, 2026 23:39
3e23d76 to
7d1cf06
Compare
baltzell
force-pushed
the
para-trig-writer
branch
2 times, most recently
from
October 23, 2026 21:00
49c419e to
8d14c5d
Compare
c-dilks
approved these changes
Oct 24, 2026
c-dilks
left a comment
c-dilks
left a comment
Member
There was a problem hiding this comment.
Looks good, but why the name ParaTrigWriter? Maybe just TrigWriter, or TrigBitWriter? We have no other such class names:
find -name '*.java' | grep -i 'trig'./common-tools/clas-analysis/src/main/java/org/jlab/analysis/eventmerger/RandomTriggerFilter.java
./common-tools/clas-analysis/src/main/java/org/jlab/analysis/eventmerger/FilterTrigger.java
./common-tools/clas-analysis/src/main/java/org/jlab/analysis/eventmerger/RandomTriggerSplit.java
./common-tools/clas-io/src/main/java/org/jlab/io/banks/RUN_trigger.java
./common-tools/clas-io/src/main/java/org/jlab/io/banks/ECAL_trigger.java
./common-tools/cnuphys/numRec/src/com/nr/example/Trigag_Ex.java
Collaborator
Author
|
Just for its intended use. Maybe we should change it ... |
baltzell
force-pushed
the
para-trig-writer
branch
from
October 25, 2026 15:27
8d14c5d to
a935160
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For adding a small output file of trigger bits in parallel.