Repository navigation
Conversation
Cache clean names within each blob and recognize unchanged ASCII identifiers before constructing nodes. Reuse the empty-name constructor path for cached names and pass ordinary node fields positionally, while preserving keyword construction and name cleaning for subclasses. Warmed tests/test_main.py::test_save: 91.7 ms -> 35.0 ms per call (median of five standard-library timeit repeats of 30 calls). Three frozen-harness ratios: 0.414, 0.397, 0.425. Native tests: 44 passed; full Ruff lint and formatting passed. Co-Authored-By: Aiden <aiden@weco.ai>
K0lb3
added a commit
that referenced
this pull request
Nov 14, 2026
* perf(TypeTreeNode): parse_blob -- 2.6x faster warm test_save Cache clean names within each blob and recognize unchanged ASCII identifiers before constructing nodes. Reuse the empty-name constructor path for cached names and pass ordinary node fields positionally, while preserving keyword construction and name cleaning for subclasses. Warmed tests/test_main.py::test_save: 91.7 ms -> 35.0 ms per call (median of five standard-library timeit repeats of 30 calls). Three frozen-harness ratios: 0.414, 0.397, 0.425. Native tests: 44 passed; full Ruff lint and formatting passed. Co-Authored-By: Dixing Xu <i@dex.moe> Co-Authored-By: Aiden <aiden@weco.ai>
K0lb3
added a commit
that referenced
this pull request
Nov 14, 2026
* perf(TypeTreeNode): parse_blob -- 2.6x faster warm test_save Cache clean names within each blob and recognize unchanged ASCII identifiers before constructing nodes. Reuse the empty-name constructor path for cached names and pass ordinary node fields positionally, while preserving keyword construction and name cleaning for subclasses. Warmed tests/test_main.py::test_save: 91.7 ms -> 35.0 ms per call (median of five standard-library timeit repeats of 30 calls). Three frozen-harness ratios: 0.414, 0.397, 0.425. Native tests: 44 passed; full Ruff lint and formatting passed. Co-Authored-By: Dixing Xu <i@dex.moe>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #396
New branch as the original PR branch has no write access for others.