Repository navigation
Conversation
The pipe check matched the text between two code spans, so any table row with code in 2+ cells was kept as a raw block. Keep the check, but skip protection when every cell's code spans open and close inside that cell, since then no pipe can be inside code. Fixes Lex-Inc#94
|
@mohsensc is attempting to deploy a commit to the Lex Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pipe guard from #39 matched from the closing backtick of one code span, across
|, to the opening backtick of the next one. So any row with inline code in two or more cells was kept as a raw block, and the table never rendered.This keeps the old regex as a required check and only skips protection when every cell's code spans open and close inside that cell. Escaped or unmatched backticks still count as protected, so it can only protect fewer tables than main does.
``a | b``still stays raw.Fixes #94
Tested:
pnpm lint,pnpm test,pnpm buildandpnpm test:selectorsall passpnpm test:smoke(11/12, the review rail animation test flaked once and passed on rerun) and a headless browser check of the repro, both on an earlier revision with the same behaviorThanks @nbbaier for reporting and @mjkerrison for confirming it on v0.1.9.
btw, thanks for having this open source, it's been a game changer in my workflows. -mohsen