Repository navigation
Prepare version 3.6.0 - #228
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Active critical findings allow shell injection through untrusted workflow inputs in a privileged job, and a moderate hard-coded branch reference can break PR builds when the upstream default changes.
3 open issues
What changed in this PR
Prepares the 3.6.0 Docker release by decoupling builds from LibreBooking's fixed branch name, introducing nightly and latest image tags, and updating documentation and deployment examples.
Changes:
- Allow builds to use the upstream default branch or an explicitly supplied ref.
- Update workflows for nightly, stable, versioned, compatibility, and latest image tags.
- Replace develop references with nightly in documentation and container examples.
| File | Description |
|---|---|
| Dockerfile | Updates upstream source checkout to support the default branch or an explicitly supplied ref. |
| BUILD.md | Documents stable-release, nightly, and local image build procedures. |
| .github/workflows/build_on_request.yml | Makes manual application and image version inputs optional. |
| .github/workflows/build_image_release.yml | Builds images from the latest upstream LibreBooking release. |
| .github/workflows/build_image_develop.yml | Renames the scheduled development image workflow to nightly and uses the upstream default branch. |
| .github/workflows/build_and_publish.yml | Computes release and compatibility tags and publishes nightly, stable, and latest image aliases. |
| .examples/podman/README.md | Updates Podman examples to use the nightly image. |
| .examples/kubernetes/README.md | Updates the Kubernetes example to use the nightly image. |
| .examples/docker/README.md | Updates Docker examples to use the nightly image. |
| .examples/docker/docker-compose-public.yml | Changes public Compose image defaults to nightly. |
| .examples/docker/docker-compose-local.yml | Changes local Compose image defaults to nightly. |
| .examples/docker/.env | Updates the example stable application image version. |
Review effort: Lite
|
Hi @JohnVillalovos , the check_build.yml github action is failing while it should not, as I succesfully created nightly and release images in colisee/librebooking. I believe the building steps should be reviewed... I will review the copilot code reviews Finally, like last time, all commits should be squashed upon merging the PR |
JohnVillalovos
left a comment
There was a problem hiding this comment.
I think the Copilot review explains why the build failed.
Yes, with the new Dockerfile one no longer uses |
|
OK, I think I am done. If you are OK with the PR, please squash upong merging. |
JohnVillalovos
left a comment
There was a problem hiding this comment.
This review was written by Claude (an AI assistant), reviewing at the request of John Villalovos.
Thanks for this. Moving to a nightly tag and building the upstream default branch when APP_GH_REF is empty is a good direction, and keeping develop as an alias is considerate toward existing users. I left some line comments. The main ones:
- Dockerfile: a local
docker build .with no--build-arg APP_GH_REFnow fails withAPP_GH_REF: parameter not set. I reproduced this with podman. CI isn't affected because it always passes the argument. - build_and_publish.yml: some values that come from
workflow_dispatchinput are still written directly intorun:scripts, so the shell-injection mitigation is incomplete. - Empty
with:/env:values: these are YAMLnull. Since the inputs are now optional, the keys can just be removed.
A few things outside the changed lines:
build_image_develop.yml:10andbuild_image_release.yml:21haveuses: $/.github/workflows/build_and_publish.yml. This was already the case on master, but$/doesn't look like a valid path.build_on_request.ymluses./. If the scheduled job can't resolve this, nightly images won't be built.RUN.md:9and.examples/kubernetes/README.md:25still link to upstream.../blob/develop/.... These links will break when upstream renamesdevelop→main, which is the reason given for this PR.- This changes behavior:
APP_GH_REF=refs/heads/<branch>, the formBUILD.mdused to document, no longer works. After a plaingit clonethere is no localrefs/heads/<branch>. Tags, SHAs and short branch names still work. Could this go in the PR description or docs? - Commit history: there are 19 commits, including a commit plus its revert (
2229a11/6a0bb95) and several "Fix syntax"/"Fix test" commits. Could these be squashed into one commit, or a few logical ones, with a message that explains the tag scheme and the breaking change?
6a0bb95 to
32c731c
Compare
Apply Claude recommendations for BUILD.md
Apply Claude recommedations for Dockerfile
|
@colisee Would you mind resolving the conversations that have been resolved? |
|
All systems green. Ready for lift off |
There was a problem hiding this comment.
🟡 Changes recommended
Approval is blocked by two critical reusable-workflow path errors that prevent scheduled and release image publication, plus a moderate Dockerfile checkout regression for fully qualified branch refs.
3 open issues
3 resolved since last review
Review effort: Lite
…checkout' `git clone` does not accept a branch path such as refs/heads/branch_name or refs/tags/tag_name. If/when github action is called by the upstream repository (librebooking/librebooking) we should make sure to keep the basename only Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
I must say that I am really bluffed by Copilot ! The way it looks at the overall solution and the source history is unbelievable. On top of that, my next step would have been to propose upstream to invoke |
There was a problem hiding this comment.
🔵 Needs a closer look
Live CI or workflow validation is still needed because the changes span reusable GitHub Actions, release lookups, and registry tag publication paths that cannot be verified from the source snapshot.
No open issues 🎉
3 resolved since last review
Review effort: Lite


Changes
nightlyimage tag which will replace thedevelopimage tag in the next release of this repositorylatestimage tag which tracks the latest stable release of librebooking/librebooking