Skip to content

Prepare version 3.6.0 - #228

Merged
colisee merged 10 commits into
LibreBooking:masterfrom
colisee:nightly
Nov 16, 2026
Merged

colisee merged 10 commits into
LibreBooking:masterfrom
colisee:nightly

Conversation

@colisee

@colisee colisee commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Changes

  • Adapt the github actions to be independent from the librebooking/librebooking default branch name
  • Introduce the nightly image tag which will replace the develop image tag in the next release of this repository
  • Introduce the latest image tag which tracks the latest stable release of librebooking/librebooking

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Active critical findings allow shell injection through untrusted workflow inputs in a privileged job, and a moderate hard-coded branch reference can break PR builds when the upstream default changes.

3 open issues
What changed in this PR

Prepares the 3.6.0 Docker release by decoupling builds from LibreBooking's fixed branch name, introducing nightly and latest image tags, and updating documentation and deployment examples.

Changes:

  • Allow builds to use the upstream default branch or an explicitly supplied ref.
  • Update workflows for nightly, stable, versioned, compatibility, and latest image tags.
  • Replace develop references with nightly in documentation and container examples.
File Description
Dockerfile Updates upstream source checkout to support the default branch or an explicitly supplied ref.
BUILD.md Documents stable-release, nightly, and local image build procedures.
.github/​workflows/​build_on_request.yml Makes manual application and image version inputs optional.
.github/​workflows/​build_image_release.yml Builds images from the latest upstream LibreBooking release.
.github/​workflows/​build_image_develop.yml Renames the scheduled development image workflow to nightly and uses the upstream default branch.
.github/​workflows/​build_and_publish.yml Computes release and compatibility tags and publishes nightly, stable, and latest image aliases.
.examples/​podman/​README.md Updates Podman examples to use the nightly image.
.examples/​kubernetes/​README.md Updates the Kubernetes example to use the nightly image.
.examples/​docker/​README.md Updates Docker examples to use the nightly image.
.examples/​docker/​docker-compose-public.yml Changes public Compose image defaults to nightly.
.examples/​docker/​docker-compose-local.yml Changes local Compose image defaults to nightly.
.examples/​docker/​.env Updates the example stable application image version.

Review effort: Lite

Comment thread .github/workflows/build_and_publish.yml Resolved
Comment thread .github/workflows/build_and_publish.yml Resolved
Comment thread Dockerfile Resolved
@colisee

colisee commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator Author

Hi @JohnVillalovos , the check_build.yml github action is failing while it should not, as I succesfully created nightly and release images in colisee/librebooking. I believe the building steps should be reviewed...

I will review the copilot code reviews

Finally, like last time, all commits should be squashed upon merging the PR

@JohnVillalovos JohnVillalovos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Copilot review explains why the build failed.

@colisee

colisee commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator Author

I think the Copilot review explains why the build failed.

Yes, with the new Dockerfile one no longer uses develop to generate a nightly image.
This is done. Now I need to understand the Copilot security recommendations and implement them

@colisee

colisee commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator Author

OK, I think I am done.
Sorry for the "shitty" commits history, but I couldn't find a way to test the github actions locally (I tried with nektos/act but the standard image does not include the github cli); hence this long non-squashed commits.

If you are OK with the PR, please squash upong merging.

@JohnVillalovos JohnVillalovos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review was written by Claude (an AI assistant), reviewing at the request of John Villalovos.

Thanks for this. Moving to a nightly tag and building the upstream default branch when APP_GH_REF is empty is a good direction, and keeping develop as an alias is considerate toward existing users. I left some line comments. The main ones:

  1. Dockerfile: a local docker build . with no --build-arg APP_GH_REF now fails with APP_GH_REF: parameter not set. I reproduced this with podman. CI isn't affected because it always passes the argument.
  2. build_and_publish.yml: some values that come from workflow_dispatch input are still written directly into run: scripts, so the shell-injection mitigation is incomplete.
  3. Empty with:/env: values: these are YAML null. Since the inputs are now optional, the keys can just be removed.

A few things outside the changed lines:

  • build_image_develop.yml:10 and build_image_release.yml:21 have uses: $/.github/workflows/build_and_publish.yml. This was already the case on master, but $/ doesn't look like a valid path. build_on_request.yml uses ./. If the scheduled job can't resolve this, nightly images won't be built.
  • RUN.md:9 and .examples/kubernetes/README.md:25 still link to upstream .../blob/develop/.... These links will break when upstream renames develop → main, which is the reason given for this PR.
  • This changes behavior: APP_GH_REF=refs/heads/<branch>, the form BUILD.md used to document, no longer works. After a plain git clone there is no local refs/heads/<branch>. Tags, SHAs and short branch names still work. Could this go in the PR description or docs?
  • Commit history: there are 19 commits, including a commit plus its revert (2229a11/6a0bb95) and several "Fix syntax"/"Fix test" commits. Could these be squashed into one commit, or a few logical ones, with a message that explains the tag scheme and the breaking change?

Comment thread Dockerfile Resolved
Comment thread Dockerfile Resolved
Comment thread .github/workflows/build_and_publish.yml Resolved
Comment thread .github/workflows/build_and_publish.yml Resolved
Comment thread .github/workflows/build_and_publish.yml Resolved
Comment thread .github/workflows/build_on_request.yml Resolved
Comment thread BUILD.md Resolved
Comment thread BUILD.md Resolved
Robin Alexander added 2 commits November 13, 2026 18:15
Apply Claude recommendations for BUILD.md
Apply Claude recommedations for Dockerfile
@JohnVillalovos

Copy link
Copy Markdown
Collaborator

@colisee Would you mind resolving the conversations that have been resolved?

@colisee

colisee commented Nov 15, 2026

Copy link
Copy Markdown
Collaborator Author

All systems green. Ready for lift off

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Approval is blocked by two critical reusable-workflow path errors that prevent scheduled and release image publication, plus a moderate Dockerfile checkout regression for fully qualified branch refs.

3 open issues
3 resolved since last review

Review effort: Lite

Comment thread Dockerfile Resolved
…checkout'

`git clone` does not accept a branch path such as refs/heads/branch_name or refs/tags/tag_name. 

If/when github action is called by the upstream repository (librebooking/librebooking) we should make sure to keep the basename only

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@colisee

colisee commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator Author

I must say that I am really bluffed by Copilot ! The way it looks at the overall solution and the source history is unbelievable. On top of that, my next step would have been to propose upstream to invoke build_and_publish.yml when a new release is created...

@JohnVillalovos
JohnVillalovos requested a lite review from Copilot November 16, 2026 18:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Live CI or workflow validation is still needed because the changes span reusable GitHub Actions, release lookups, and registry tag publication paths that cannot be verified from the source snapshot.

No open issues 🎉

3 resolved since last review

Review effort: Lite

@JohnVillalovos JohnVillalovos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I don't see any issues.

Thanks @colisee

Please merge whenever you are ready.

@colisee
colisee merged commit 3f69d23 into LibreBooking:master Nov 16, 2026
3 checks passed
@colisee
colisee deleted the nightly branch November 16, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants