Repository navigation
fix(host): keep per-host overrides from becoming the app-wide default - #11
Open
andreas-byfut wants to merge 1 commit into
Open
andreas-byfut wants to merge 1 commit into
andreas-byfut wants to merge 1 commit into
Conversation
The app-wide terminal profile and colour scheme are the lowest-id rows, and Settings only inserts them on the first edit. Creating a host's first override before that inserted it as the lowest-id row, so every host picked it up as the default. insertOverride() on both DAOs now writes the default row first when it is missing, then the override, in one transaction.
Owner
|
Thanks. Good fix. This will resolve for new installs, however pre-existing isntalls stay broken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app-wide terminal profile and colour scheme are the lowest-id rows in their tables, and
Settings only inserts them on the first edit. If a host's first override was enabled before that,
the override became the lowest-id row, and every host picked it up as the default.
TerminalProfileDao.insertOverride()andColorSchemeDao.insertOverride()now insert the defaultrow first when none exists, then the override, in one
@Transaction. There is no schema change.Known limit: installs where an override already became the default are not repaired. The override
cannot be told apart from a deliberately edited default.
Tests:
InsertOverrideTest.