Repository navigation
fix(terminal): send AltGr characters instead of ESC-prefixing them - #13
Closed
andreas-byfut wants to merge 1 commit into
Closed
andreas-byfut wants to merge 1 commit into
andreas-byfut wants to merge 1 commit into
Conversation
On layouts with AltGr (e.g. German AltGr+Q = @), Android reports Right Alt as Alt, so the hardware key handler sent ESC plus the unmodified base character (ESC q) instead of the composed character. Right Alt now sends the composed character as is when it changes the character. Behaviour change: this also applies to Right Alt on layouts without AltGr that still define Alt mappings, such as the AOSP Generic layout (C and S map to ç and ß), which now send those characters instead of ESC+letter. Right Alt keeps the ESC prefix where it composes nothing. Left Alt is unchanged and always sends ESC+base character. AltGr dead keys (no printable composed character) still fall back to ESC+base, as before. The decision is a pure function, altChordText.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On layouts with AltGr (for example German, where AltGr+Q gives @), Android reports Right Alt as
Alt. The hardware key handler therefore sent ESC plus the base character instead of the composed
one.
Generic (C and S map to ç and ß), Right Alt now sends those characters.
The decision is the pure function
altChordText, covered byAltChordTextTest.