Repository navigation
fix(transfer): report unverified uploads as failures and truncate on download - #14
Merged
LordOfPolls merged 1 commit intoNov 14, 2026
Conversation
…download uploadFile returned success when the post-upload stat failed, although its KDoc treats that as a failure; it now returns a failure. Downloads opened the SAF destination with mode "w", which many document providers do not truncate, leaving stale trailing bytes when overwriting a longer file. Use "wt".
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uploadFilereturned success when the post-uploadstatfailed, although its KDoc counts thatas a failure, and the download path already treats an unconfirmed transfer as one. It now
returns a failure: "Uploaded, but could not confirm the file's size on the server".
"w", which many document providers do nottruncate. Overwriting a longer file left stale bytes at the end. They now use
"wt", asConfigExportalready does. Append stays"wa".Note: a transient
staterror now shows a completed upload as failed.Tests:
UriFileTransferTest.