Repository navigation
fix(terminal): mouse and keyboard clipboard support - #7
Open
andreas-byfut wants to merge 3 commits into
Open
andreas-byfut wants to merge 3 commits into
andreas-byfut wants to merge 3 commits into
Conversation
…nsert and Ctrl+Shift+C Ctrl+Shift+V and Shift+Insert paste, Ctrl+Shift+C copies the selection. Plain Ctrl+C and Ctrl+V still reach the remote as control bytes.
…der the finger The column count came from the truncated cell width while the renderer draws at the fractional one, so the last column could be cut off and taps, selection and handles drifted right across the row.
…y or paste With a mouse the wheel did nothing and a press-drag scrolled the scrollback instead of selecting. The wheel now scrolls the scrollback, sends wheel events to a mouse-tracking app, or sends arrow keys on the alternate screen. A drag selects, a double-click selects a word, and a right-click copies the selection or pastes. Shift bypasses mouse tracking, as in xterm. Touch is unchanged.
Owner
|
Hi there, thanks for all the PRs. As I'm sure you can appreciate, 10 PRs touching various parts of the codebase will take a bit to review. However, before I review, please can you confirm if these were physically tested, i.e. with a device, not just the unit tests? |
Contributor
Author
|
Hey, of course, take your time. I have been using Shellwave with the fixes the last three days on a regular basis - mutliple hours with several reconnects. Thanks again for this great app. |
Owner
|
Thanks, this works. Minor changes please.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a physical keyboard and mouse there was no way to paste, the wheel did nothing, and a
press-drag scrolled instead of selecting. These are three commits that build on each other:
Paste and copy shortcuts: Ctrl+Shift+V and Shift+Insert paste, and Ctrl+Shift+C copies the
selection. Plain Ctrl+C and Ctrl+V still reach the remote as control bytes. Ctrl+Shift+C with
no selection is swallowed, as in desktop terminals.
Fractional cell width: the column count came from the truncated cell width while the
renderer draws at the fractional one. That cut off the last column, and taps, selection and
handles drifted right across the row.
Mouse: what the wheel does depends on the screen:
A drag selects, a double-click selects a word, and a right-click copies the selection or
pastes. Shift bypasses mouse tracking, as in xterm. Touch behaviour is unchanged.
Tests:
ClipboardShortcutTest,TerminalCanvasTest,TerminalGesturesTest.Known limits:
the link dialog.