Repository navigation
fix(session): show the selected session's terminal after a tab switch - #9
Open
andreas-byfut wants to merge 1 commit into
Open
andreas-byfut wants to merge 1 commit into
andreas-byfut wants to merge 1 commit into
Conversation
Switching to a disconnected, failed or reconnecting tab kept drawing the previous session's emulator, and selecting or copying then acted on the wrong buffer. - Each SessionTabBody call site is wrapped in key(sessionId), so every session gets its own emulator, scrollback, selection and latched modifiers. - The body adopts the connection's emulator for any status except CONNECTING, so a dropped or reconnecting session keeps showing its last screen. - The pinch-zoomed font size lives in SessionBodyShared, outside the key, so it is still shared across tabs. - The terminal field no longer shows the keyboard when it gains focus. A freshly composed field takes focus on every tab switch and would otherwise raise it. - Tapping the terminal shows the keyboard explicitly. - SessionBodyShared.shown tells the first body composed after entering the Sessions screen from one composed by a tab switch. The first raises the keyboard, as before; a switch keeps it up only if it was up. Not tested on a device: the keyboard behaviour needs a device check.
Owner
|
Thanks, was able to replicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching to a disconnected, failed or reconnecting tab kept drawing the previous session's
emulator, and selecting or copying then acted on the wrong buffer.
SessionTabBodycall site is wrapped inkey(sessionId), so every session gets its ownemulator, scrollback, selection and latched modifiers.
CONNECTING, so a dropped orreconnecting session keeps its last screen.
SessionBodyShared, outside the key, so it is still sharedacross tabs.
TerminalInputCapturesetsshowKeyboardOnFocus = false, so a freshly composed field does notraise the keyboard on every tab switch. A tap on the terminal now shows it explicitly.
SessionBodyShared.shownmarks the first body composed after entering the Sessions screen. Thatone raises the keyboard, as before. A tab switch keeps the keyboard up only if it was already up.
Behaviour change: the keyboard no longer comes back by itself when focus returns after the link
dialog or the overflow menu closes. Tap the terminal or the keyboard key to bring it back.