Repository navigation
Conversation
dbt runs tests on 4 threads, so the order of dataQualityAssertions.assertions in the test COMPLETE events changes from run to run, and the csv_to_postgres expectations fail at random (seen on customer_analytics: total_revenue and customer_id not_null swapped). Compare the assertions with unordered_list. That needed a fix in compare_events: unordered_list called the module's own any() (the jinja helper, which returns a string) instead of the builtin and compared lists with `is []`, so it never matched anything. No expectation used it until now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: tnazarew <tomasz.nazarewicz@getindata.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dbt runs tests on 4 threads, so the order of
dataQualityAssertions.assertionsin the test COMPLETE events changes from run to run. Thecsv_to_postgresexpectations added in #357 therefore fail at random, e.g. run 43859743388:Changes
csv_to_postgresdata quality expectations compareassertionswithunordered_list.compare_events.diff:unordered_listnever matched. It called the module's ownany()jinja helper (which returns a string) instead of the builtin and compared withis []. Now it usesbuiltins.any(... == []). No expectation usedunordered_listbefore, so nothing else changes.Testing
Replayed the real events from run 43859743388 (dbt 1.8.0 × OpenLineage 1.55.0):
Unit tests for
unordered_listare in #353 (scripts/tests/test_compare_events.py); main has no script test setup until #352.🤖 Generated with Claude Code