Skip to content

Raise error when model time dimension is not strictly increasing - #3063

Merged
erikvansebille merged 2 commits into
Parcels-code:mainfrom
erikvansebille:fix_nonincreasing_model_time
Nov 16, 2026
Merged

erikvansebille merged 2 commits into
Parcels-code:mainfrom
erikvansebille:fix_nonincreasing_model_time

Conversation

@erikvansebille

Copy link
Copy Markdown
Member

Description

This PR introduces a ValueError when the time dimension is not monotonically increasing.

It also fixes a small bug in the progress bar that I spotted while developing: the final time printed was the second-last time in the loop

Checklist

AI Disclosure

N/A

@wyatt-fluidnumerics wyatt-fluidnumerics left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@erikvansebille
erikvansebille merged commit 9841b5c into Parcels-code:main Nov 16, 2026
49 of 52 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Parcels development Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

More informative error messaging if time index is not increasing

2 participants