Skip to content

Read report cliffs from simulation runs' cliff results, and take include_cliffs on re-runs #4328

Open

Description

@anth-volk

/v2/reports reads a report run's cliff impact from report_runs' four cliff columns (baseline_cliff_gap, baseline_cliff_share, reform_cliff_gap, reform_cliff_share). Cliffs are now a calculation of a simulation run: each simulation run can have one cliff result (cliff_impacts, #4327), calculated once when a request asks for it and shared by every report naming the run. The simulation service stops writing the four columns, and a later revision drops them.

The Public API needs to:

  • read each economy report run's cliff impact from its two simulation runs' cliff results, once both have succeeded, and stop reading the four columns;
  • say on each economy report read how far the two cliff calculations have got (none, pending, running, succeeded or failed, with the failure's message), since they finish apart from the report run;
  • take include_cliffs on POST /v2/reports/{report_id}/runs as well as on the create, and pass it to the simulation service, which starts each side's cliff calculation;
  • refuse include_cliffs for household reports and budget windows, which have no cliffs.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions