Skip to content

Revert "Platform-aware Install-PSResource: filter runtimes by RID, li… - #2070

Merged
alerickson merged 4 commits into
masterfrom
revert-platform-aware-install
Oct 19, 2026
Merged

alerickson merged 4 commits into
masterfrom
revert-platform-aware-install

Conversation

@alerickson

@alerickson alerickson commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

…bs by TFM (#1963)"

This reverts commit 156083a.

PR Summary

Reverts PR: #1963

due to issues with loading modules like Az.Accounts in Windows PowerShell.

For example, Az.Accounts in Windows PowerShell needs access to the following directories:
image

However, PR #1963 only installs the net47 lib directory.

PR Context

PR Checklist

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Remaining references to deleted fields block compilation, and the CI reversions undo authentication and cleanup fixes.

3 open issues
What changed in this PR

Reverts platform-aware installation from #1963 to address module-loading failures in Windows PowerShell, including Az.Accounts.

Changes:

  • Removes runtime/framework filtering, override parameters, and merge installation.
  • Restores previous dependency handling and removes related helpers and tests.
  • Reverts two independent CI fixes.
File Description
test/​PSResourceInfo.Tests.ps1 Removes empty dependency-group coverage.
test/​PlatformFilteringTests/​RuntimePackageHelper.Tests.ps1 Deletes runtime asset tests.
test/​PlatformFilteringTests/​RuntimeIdentifierHelper.Tests.ps1 Deletes runtime compatibility tests.
test/​PlatformFilteringTests/​PlatformAwareInstall.Tests.ps1 Deletes platform-aware installation tests.
src/​code/​Utils.cs Removes directory merging helper.
src/​code/​RuntimePackageHelper.cs Deletes runtime asset filtering helper.
src/​code/​RuntimeIdentifierHelper.cs Deletes runtime detection helper.
src/​code/​PSResourceInfo.cs Restores previous dependency parsing.
src/​code/​InternalHooks.cs Removes platform test hooks.
src/​code/​InstallPSResource.cs Removes platform override parameters.
src/​code/​InstallHelper.cs Removes filtering and merge behavior.
src/​code/​ArgumentCompleter.cs Removes platform parameter completions.
.ci/​test.yml Removes token fallback and cleanup shell selection.

Review effort: Balanced

Comment thread .ci/test.yml
Comment thread .ci/test.yml
Comment thread src/code/InstallHelper.cs
Copilot AI and others added 3 commits October 19, 2026 21:01
Co-authored-by: alerickson <25858831+alerickson@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Add check for GITHUB_TOKEN before removing Authorization header

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@alerickson

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@alerickson
alerickson merged commit 9a50b92 into master Oct 19, 2026
12 checks passed
@alerickson
alerickson deleted the revert-platform-aware-install branch October 19, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants