Repository navigation
Conversation
Add dock type codes 48 (F1RC) and 50 (F2RS), app-name aliases for codes 27 and 49, the capabilities of codes 48-50, and three new dock properties. K1S gets automatic fluid delivery, Hera the hatch-door cool fan, and F2R no longer reports carousel self-cleaning, following the newest app plugins.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings
RoborockDockTypeCodeandRoborockDockFeaturesin line with the dock table (DockConfigs) of the newest Roborock app V1 plugins.f1rc_dock = 48andf2rs_dock = 50. Until now these codes fell back tounknown, so the dock counted as missing and no dock traits were offered.shell_4_dock(27) andf1rs_dock(49).type_27_dockandtype_49_dockstay the canonical names, so.name,keys()and existing code are unchanged.is_no_support_hot_wash_towel(Shell E): the app disables hot mop washing for this dock even when the robot reports it.is_multi_clean_fluid_supported(Shell 4S without AM).is_clean_carousel_supported(dock has a carousel/strainer).docs/V1_DEVICE_FEATURES.md. It explains that the app's "A"/"AM" variants (Shell 2SA, O5AM, ...) are not separate codes: they report the samedock_typeand differ byStatus.has_am.Changed existing values
These results change for docks the library already knew. Each follows the newest app plugins.
is_clean_carousel_self_clean_supportedis_clean_fluid_auto_delivery_supportedis_hatch_door_dock_cool_fan_supportedCouple or Hera.Known difference, not changed here
is_special_support_wash_tempis True only for the Shell 2E Lite dock. The app's check of the same name also depends on the product: it is true for every product except PearlEPro, which needs a Shell 2E Lite dock. The library does not use this property yet. It will be fixed when the wash temperature options start using it.Testing
tests/test_supported_features.pyfor each new code and changed value, with and without AM, and for the aliases.pre-commit run --all-filesand the fullpytestsuite pass.Part of #738