Skip to content

Update Leiningen to 2.13.1 - #306

Open
cap10morgan wants to merge 4 commits into
masterfrom
update/leiningen
Open

cap10morgan wants to merge 4 commits into
masterfrom
update/leiningen

Conversation

@cap10morgan

@cap10morgan cap10morgan commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Upgrade Leiningen to 2.13.1, pinning the release tag to its commit d109a01c ("Release 2.13.1").
  • Keep Leiningen's signing key in the repo. Lein builds fetched the key from keyserver.ubuntu.com and failed whenever that timed out, which happens often when building many images in parallel. Builds now import resources/lein-signing-key.asc and check it's the pinned fingerprint; they don't contact a keyserver.
  • Check the vendored key in CI. A new lein-key job runs bb check-lein-key, which compares our copy with the keyserver's:
    • matches → pass
    • differs (revoked, expiry changed, new subkey or user ID) → fail, printing both copies and pointing at bb refresh-lein-key
    • keyserver unreachable → warning annotation, pass
  • Add bb refresh-lein-key, which fetches the key, checks it's the pinned fingerprint, and writes a minimal export to resources/.
  • Shorten smoke test log lines. The lein routing check passed its whole script and Clojure form as arguments, so each image logged ~25 lines; multi-line args now log as a line count and long args are truncated.

Regenerated Dockerfiles aren't included; CI regenerates target/ on master.

Testing

  • bb test (28 tests, 0 failures) and bb fmt-check pass.
  • Local arm64 builds with smoke tests via bb build-images: lein on Debian, Ubuntu (jammy, noble, resolute) and Alpine, plus latest. Rebuilt Debian, Alpine and latest after moving the keyserver check to CI.
  • A build with a different key in lein-signing-key.asc fails at the fingerprint check, before cloning Leiningen.
  • bb check-lein-key: passes with our key, fails with a copy missing its subkey, and warns but passes when the keyserver is unreachable.
  • bb refresh-lein-key leaves an up-to-date key file byte-for-byte unchanged and restores a modified one.

🤖 Generated with Claude Code

cap10morgan and others added 3 commits November 11, 2026 10:36
Pin the 2.13.1 release tag to its commit, d109a01c ("Release 2.13.1").

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lein builds fetched the release signing key from keyserver.ubuntu.com and
failed whenever it timed out, which happens often when building many
images in parallel. Import a copy kept in resources/ instead, and still
check it against the keyserver: fail with instructions if the keyserver's
copy differs (e.g. the key was revoked, extended or gained a subkey), and
carry on with the local copy if the keyserver can't be reached.

Add `bb refresh-lein-key` to update the local copy from the keyserver.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The lein routing check passes its whole script and Clojure form as
arguments, so logging each command printed ~25 lines per image. Log
multi-line args as a line count and truncate long ones.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cap10morgan

Copy link
Copy Markdown
Collaborator Author

@Quantisan I did a little more than just a version bump in here, so wanted your review. Thanks!

@Quantisan Quantisan left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! vendoring the key seems reasonable. I'm not sure if it should be code in the image's Dockerfile. Can we do the key server comparison in our CI here, perhaps?

Per review, keep the keyserver comparison out of the image Dockerfiles.
Builds now only import the key from resources/ and check it's the pinned
fingerprint. A new `lein-key` CI job runs `bb check-lein-key`, which fails
if the keyserver's copy differs from ours and warns (without failing) if
the keyserver can't be reached.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cap10morgan

Copy link
Copy Markdown
Collaborator Author

@Quantisan Good call, done in e98af30. The Dockerfiles now only import the vendored key and check it's the pinned fingerprint; they don't contact a keyserver at all. The comparison moved to a new lein-key CI job that runs bb check-lein-key: it fails if the keyserver's copy differs from ours (e.g. a revocation or new subkey) and just warns if the keyserver can't be reached, so an outage won't turn PRs red. bb refresh-lein-key updates the vendored copy when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants