Repository navigation
Update Leiningen to 2.13.1 - #306
cap10morgan wants to merge 4 commits into
Conversation
Pin the 2.13.1 release tag to its commit, d109a01c ("Release 2.13.1").
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lein builds fetched the release signing key from keyserver.ubuntu.com and failed whenever it timed out, which happens often when building many images in parallel. Import a copy kept in resources/ instead, and still check it against the keyserver: fail with instructions if the keyserver's copy differs (e.g. the key was revoked, extended or gained a subkey), and carry on with the local copy if the keyserver can't be reached. Add `bb refresh-lein-key` to update the local copy from the keyserver. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The lein routing check passes its whole script and Clojure form as arguments, so logging each command printed ~25 lines per image. Log multi-line args as a line count and truncate long ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@Quantisan I did a little more than just a version bump in here, so wanted your review. Thanks! |
Quantisan
left a comment
There was a problem hiding this comment.
Thanks! vendoring the key seems reasonable. I'm not sure if it should be code in the image's Dockerfile. Can we do the key server comparison in our CI here, perhaps?
Per review, keep the keyserver comparison out of the image Dockerfiles. Builds now only import the key from resources/ and check it's the pinned fingerprint. A new `lein-key` CI job runs `bb check-lein-key`, which fails if the keyserver's copy differs from ours and warns (without failing) if the keyserver can't be reached. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@Quantisan Good call, done in e98af30. The Dockerfiles now only import the vendored key and check it's the pinned fingerprint; they don't contact a keyserver at all. The comparison moved to a new |
Summary
d109a01c("Release 2.13.1").resources/lein-signing-key.ascand check it's the pinned fingerprint; they don't contact a keyserver.lein-keyjob runsbb check-lein-key, which compares our copy with the keyserver's:bb refresh-lein-keybb refresh-lein-key, which fetches the key, checks it's the pinned fingerprint, and writes a minimal export toresources/.Regenerated Dockerfiles aren't included; CI regenerates
target/on master.Testing
bb test(28 tests, 0 failures) andbb fmt-checkpass.bb build-images: lein on Debian, Ubuntu (jammy, noble, resolute) and Alpine, pluslatest. Rebuilt Debian, Alpine andlatestafter moving the keyserver check to CI.lein-signing-key.ascfails at the fingerprint check, before cloning Leiningen.bb check-lein-key: passes with our key, fails with a copy missing its subkey, and warns but passes when the keyserver is unreachable.bb refresh-lein-keyleaves an up-to-date key file byte-for-byte unchanged and restores a modified one.🤖 Generated with Claude Code