Skip to content

Remove R < 3.5.0 compatibility shims from data.table.h - #7957

Merged
MichaelChirico merged 2 commits into
masterfrom
drop-r-3.5-shims
Nov 9, 2026
Merged

MichaelChirico merged 2 commits into
masterfrom
drop-r-3.5-shims

Conversation

@m-muecke

@m-muecke m-muecke commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

mainly found via grep -rn 'R 3\.[0-4]'

@codecov

codecov Bot commented Nov 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (fe94435) to head (2af88cc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7957      +/-   ##
==========================================
- Coverage   99.08%   99.08%   -0.01%     
==========================================
  Files          88       88              
  Lines       17429    17428       -1     
==========================================
- Hits        17270    17269       -1     
  Misses        159      159              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
  • HEAD=drop-r-3.5-shims much slower for transform improved in #5493

(Plot image upload to picrd.com failed; download the artifact below to view plots)

Generated via commit 2af88cc

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 1 minutes and 53 seconds
Installing different package versions 11 minutes and 34 seconds
Running and plotting the test cases 4 minutes and 40 seconds

@MichaelChirico
MichaelChirico merged commit 63a95fa into master Nov 9, 2026
15 checks passed
@MichaelChirico
MichaelChirico deleted the drop-r-3.5-shims branch November 9, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants