Repository navigation
X11: Do not use a separate thread anymore - #357
Merged
Merged
Conversation
prokopyl
force-pushed
the
x11-main-thread
branch
from
October 21, 2026 21:38
c5e68f6 to
9201959
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR overhauls the X11 implementation by not requiring everything to be sent to a separate thread.
Instead, it now properly integrates with the host's event loop, like on Windows and macOS.
Breaking Changes
Integrating with the host event loop on Linux requires implementing two new
Hostinterfaces:HostTimerSupportandHostFdSupport.HostFdSupportis optional but preferred for better performance. If not available from the host, thenHostTimerSupportis used as a fallback.Not implementing either of these interface will result in a window that cannot receive any events and will forever appear "frozen".