Repository navigation
Conversation
Require Alpine ca-certificates 20261020-r0+ in the image, bump certifi to 2026.10.19, point Node at the system store with NODE_OPTIONS=--use-openssl-ca until Node ships its fix, and bump the bundled uv to 0.13.4.
|
🐳 Docker preview published: This mutable tag is only created when a Docker preview is explicitly requested. |
1 of 9 tasks
The entrypoint now prepends --use-openssl-ca to a caller-supplied NODE_OPTIONS (e.g. a heap limit) instead of letting it replace the image default, unless the caller already picked a CA store. Also trims the 2.11.2 changelog entry to what users will notice.
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c6f5cd9. Configure here.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Docker image so its TLS clients stop trusting the eMudhra intermediate CAs whose keys were disclosed on 2026-10-20 (details). Companion to SocketDev/socket-basics#128.
Root Cause
The image's CA stores predate the distrust:
ca-certificatesfrom the base image (curl, git, Go, Java).apk adddoesn't upgrade packages the base image already has.uv.lock(Pythonrequests).Fix
Dockerfile: upgradeca-certificatesand fail the build below20261020-r0.uv.lock: certifi 2026.10.19.Dockerfileandscripts/docker-entrypoint.sh: point Node at the system store with--use-openssl-ca. The entrypoint prepends it to a caller's ownNODE_OPTIONSand skips it if the caller already chose a CA store. Can be removed once Node ships a fix.Dockerfile: uv 0.13.4.Alpine's
gopackage is still 1.26.9, so scanners will keep flagging it until Alpine updates. Its TLS uses the fixed system store.Testing
Built locally and ran each client against the two test hosts,
dv-g3b-emudhra.we-have-a-problem.comanddv-g3b-aaa-emudhra.we-have-a-problem.com. On 2.11.1, curl, Python, Node, Go and Java accept the first. On this branch, curl, git, Python, Node, uv, Go and Java reject both. api.socket.dev, the npm registry, PyPI, proxy.golang.org, Maven Central and GitHub still connect.Also checked the entrypoint with no
NODE_OPTIONS, an empty one, a heap limit, multiple flags, and an explicit--use-bundled-ca.pytest(580 passed),uv lock --locked,hatch buildandtwine checkpass.Quick check against
socketdev/cli:pr-415:docker run --rm --entrypoint curl socketdev/cli:pr-415 -sS -o /dev/null -w '%{http_code}\n' https://dv-g3b-emudhra.we-have-a-problem.com/2.11.1 prints 200; this branch fails certificate verification.
Public Changelog
The CLI and every tool in the
socketdev/cliDocker image now reject certificates issued from the compromised eMudhra intermediate CAs.Note
High Risk
Changes system-wide CA trust for every TLS client in the Docker image (Alpine, Python, Node, uv); misconfiguration could break legitimate HTTPS or leave distrusted chains accepted.
Overview
Release 2.11.2 hardens TLS across the
socketdev/cliDocker image and Python CLI so clients no longer trust certificates chained to the compromised eMudhra intermediate CAs.The Dockerfile now upgrades Alpine
ca-certificates(with a build-time floor of20261020-r0), setsNODE_OPTIONS=--use-openssl-caso Node uses the patched system store until Node ships its own fix, and bumps the bundleduvimage from 0.10.4 to 0.13.4 for updated root bundles.scripts/docker-entrypoint.shprepends--use-openssl-cawhen callers add their ownNODE_OPTIONS, without overriding an explicit CA-store flag.uv.lockpinscertifito 2026.10.19 for Python/requestsTLS. Version strings move to 2.11.2 inpyproject.toml,socketsecurity/__init__.py, and CHANGELOG.md.Reviewed by Cursor Bugbot for commit c6f5cd9. Configure here.