Skip to content

Support zarr v3 - #387

Merged
chrishalcrow merged 14 commits into
SpikeInterface:mainfrom
alejoe91:zarrv3
Oct 23, 2026
Merged

chrishalcrow merged 14 commits into
SpikeInterface:mainfrom
alejoe91:zarrv3

Conversation

@alejoe91

Copy link
Copy Markdown
Member

No description provided.

@alejoe91 alejoe91 closed this Mar 20, 2026
@alejoe91
alejoe91 deleted the zarrv3 branch March 20, 2026 09:35
@alejoe91
alejoe91 restored the zarrv3 branch March 20, 2026 09:35
@alejoe91 alejoe91 reopened this Mar 23, 2026
@alejoe91
alejoe91 marked this pull request as ready for review March 25, 2026 08:46
Comment thread src/probeinterface/__init__.py Outdated
Comment thread src/probeinterface/__init__.py Outdated
Co-authored-by: Alessio Buccino <alejoe9187@gmail.com>
No zarr 3 release supports Python 3.10, so the test dependencies of this
branch could not be installed there. The minimum Python version is now
3.11, in the package metadata, the test matrix, and the Read the Docs
build.

The test workflow set up Python 3.11 for every job, whatever the matrix
said, so the jobs named for Python 3.10 and 3.14 both ran on 3.11. It now
uses the matrix version.

Saving a probe with zarr 2 installed raises an ImportError that says zarr 3
is required, in place of an AttributeError. A new test saves a probe in a
zarr format 2 group and reads it back, since that is the format existing
files are in.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

@chrishalcrow chrishalcrow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Played a bit saving v2 and v3 probes locally - v2 ones identical to main, v3 ones looks beautiful with their .jsons.

@chrishalcrow
chrishalcrow merged commit 3b4917a into SpikeInterface:main Oct 23, 2026
9 checks passed
@h-mayorquin

Copy link
Copy Markdown
Collaborator

Thanks @chrishalcrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants