Skip to content

fix(docs): address automated accessibility findings - #2464

Merged
dancormier merged 1 commit into
mainfrom
dcormier/docs-accessibility-quick-fixes
Oct 26, 2026
Merged

dancormier merged 1 commit into
mainfrom
dcormier/docs-accessibility-quick-fixes

Conversation

@dancormier

@dancormier dancormier commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fix straightforward accessibility failures in the documentation while preserving intentional “what not to do” examples and existing visuals.

Companion scanner PR: https://github.com/StackEng/Accessibility/pull/578

Changes

  • Add contextual image alternatives and descriptive video-frame titles across the brand documentation.
  • Name glyph-picker buttons, including whitespace characters; expose the selected state and remove an unused assignment that threw during selection.
  • Label select-size examples and editor demos, replace prohibited ARIA on icon-only labels with hidden text, and associate focus-demo toggles with their captions.
  • Mark only the two intentional low-contrast demonstrations for contrast-only exclusion by the companion scanner change.
  • Add regression tests against processed documentation markup and glyph names.

Addresses missing-alternative and control-name findings associated with WCAG 1.1.1, 1.3.1, and 4.1.2. No published-package changes or changeset required.

How to test

  1. Install dependencies with npm ci, then run:
    • npm run test -w packages/stacks-docs
    • npm run check -w packages/stacks-docs
    • npm exec -w packages/stacks-docs -- eslint .
      Observed: 24 tests pass; no type errors; five warnings in unchanged files; ESLint passes.
  2. Start npm run dev -w packages/stacks-docs -- --host 127.0.0.1 --port 5174.
  3. Visit /brand/logo, /brand/color, /brand/typography, /brand/stack-system, /brand/motion, /system/forms/select, /system/components/toggle-switch, /system/accessibility/intro, and /system/components/editor. Check names and form interactions. Keyboard-select whitespace glyphs and confirm their pressed state updates.
  4. Local scanner verification covered all nine pages in all four themes. Remaining findings are contrast-related. Embedded third-party video content was not audited.
  5. Production-style Vite build passed using the repository’s CI auth placeholder. Production SLO recovery remains unverified until deployment and subsequent audits.

Preview: https://deploy-preview-2464--stacks.netlify.app — pending automatic Netlify build; not yet available.

A documentation-only merge requires a maintainer to run the “Deploy docs” workflow, or deployment with a later package release, before production audits see these fixes.

@netlify

netlify Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for stackoverflow-email ready!

Name Link
🔨 Latest commit 2a6bf11
🔍 Latest deploy log https://app.netlify.com/projects/stackoverflow-email/deploys/6adf81b310db7a8b332991d0
😎 Deploy Preview https://deploy-preview-2464--stackoverflow-email.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for stacks ready!

Name Link
🔨 Latest commit 2a6bf11
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/6adf81b382e2fb03c1bf06ce
😎 Deploy Preview https://deploy-preview-2464--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for stacks-svelte ready!

Name Link
🔨 Latest commit 2a6bf11
🔍 Latest deploy log https://app.netlify.com/projects/stacks-svelte/deploys/6adf81b3a2cdf8e63963d101
😎 Deploy Preview https://deploy-preview-2464--stacks-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@dancormier
dancormier marked this pull request as ready for review October 26, 2026 17:34
@dancormier
dancormier requested a review from a team as a code owner October 26, 2026 17:34
@dancormier
dancormier merged commit 2b27e21 into main Oct 26, 2026
31 of 32 checks passed
@dancormier
dancormier deleted the dcormier/docs-accessibility-quick-fixes branch October 26, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant