Repository navigation
Plugins: pick dark controls from ThemeColors.IsDark - #345
Merged
Merged
Conversation
The variant came from the theme name only, so dark themes not named "Dark" (Nord, Cinema, ...) and "System" on a dark OS got light Fluent controls on a dark window. IsDark now wins; older SE versions without ThemeColors still fall back to the name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PluginAppchose the light/dark variant only from the theme name, so only a theme named exactly "Dark" got dark controls. Dark themes like Nord and Cinema, and "System" on a dark OS, got a dark window (fromThemeColors) with light Fluent checkboxes, buttons and radio buttons.PluginApp.ResolveThemeVariant(PluginRequest):ThemeColors.IsDarkwins. SE computes it withUiTheme.IsDarkThemeEnabled(). Older SE versions withoutThemeColorsstill fall back to the name. The string overload is kept.App, so it gets the same change.AmericanToBritish.Tests/PluginAppTests.cs, because Plugin-Shared has no test project of its own.Every plugin built on
PluginApppicks this up on its next release.🤖 Generated with Claude Code