Repository navigation
Fix figurative requests for spoken information in Portuguese - #353
Merged
niksedk merged 1 commit intoNov 5, 2026
Merged
Conversation
Use aligned English and recent news/information context to distinguish tell-me requests from literal handovers, preserving address and complete complements. Add regression and batch tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #348: handle figurative requests for spoken information rather than literal object handovers.
Gimme/Give it to mecan resolve an isolatedDê-metoDiga-me.Só seialigned withI just knowbecomesSimplesmente sei.Dê-me as más notícias, literal handovers, missing evidence and ambiguous repeated requests remain unchanged by this stage.spoken-information.Validation
Based on current upstream
main, retaining the official 1.3.0 manifest and upstream maintenance changes.PTPT_TEST_UI=1 xvfb-run -a dotnet test se5/BrazilianToEuropeanPortuguese.Tests/BrazilianToEuropeanPortuguese.Tests.csproj -c Release2,561 passed, 7 opt-in integration/model tests skipped, 0 failures.
One existing duplicate InlineData warning remains.
The local packaged implementation was also checked against the supplied episode and English reference: the target dialogue was corrected and all 756 cues/timestamps preserved. No subtitle files or corpora are included in this PR.
Version bump and publication are left to the upstream release workflow.