Skip to content

Fix figurative requests for spoken information in Portuguese - #353

Merged
niksedk merged 1 commit into
SubtitleEdit:mainfrom
SMAP-git:fix-spoken-information-requests
Nov 5, 2026
Merged

niksedk merged 1 commit into
SubtitleEdit:mainfrom
SMAP-git:fix-spoken-information-requests

Conversation

@SMAP-git

@SMAP-git SMAP-git commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #348: handle figurative requests for spoken information rather than literal object handovers.

  • With a nearby short Portuguese topic about news, details, truth or an explanation, English Gimme / Give it to me can resolve an isolated Dê-me to Diga-me.
  • An explicit English information object also provides this evidence.
  • In the same guarded construction, Só sei aligned with I just know becomes Simplesmente sei.
  • Preserve formal/informal address, dialogue breaks, tags and timings. Complete objects such as Dê-me as más notícias, literal handovers, missing evidence and ambiguous repeated requests remain unchanged by this stage.
  • Requires Colloquial + Vocabulary; independently disabled with spoken-information.
  • Document the rule and add positive, negative, register, option-gating and split-English-cue batch tests.

Validation

Based on current upstream main, retaining the official 1.3.0 manifest and upstream maintenance changes.

PTPT_TEST_UI=1 xvfb-run -a dotnet test se5/BrazilianToEuropeanPortuguese.Tests/BrazilianToEuropeanPortuguese.Tests.csproj -c Release

2,561 passed, 7 opt-in integration/model tests skipped, 0 failures.
One existing duplicate InlineData warning remains.

The local packaged implementation was also checked against the supplied episode and English reference: the target dialogue was corrected and all 756 cues/timestamps preserved. No subtitle files or corpora are included in this PR.

Version bump and publication are left to the upstream release workflow.

Use aligned English and recent news/information context to distinguish tell-me requests from literal handovers, preserving address and complete complements. Add regression and batch tests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@niksedk
niksedk merged commit 71756ac into SubtitleEdit:main Nov 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants