Repository navigation
BrazilianToEuropeanPortuguese v1.6.0: grammar fixes and personal name articles - #359
Merged
niksedk merged 3 commits intoNov 9, 2026
Merged
Conversation
Generalize contextual vocabulary, clause agreement, clitic placement and reference-driven corrections. Add editable name article settings and preview-only automatic questions while preserving headless batch conversion. Emit native executable manifests for self-contained publishes and update bilingual guides and regression tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Cover conjugated harmful slang, personal clitics, abstract objects and reference-confirmed uses while preserving literal and unresolved senses. Add regression tests and bilingual dictionary-grounded documentation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Extend the existing recipient conversion beyond para to a, reuse clitic placement across supported tenses and contexts, and handle reviewed intervening objects. Preserve emphasized, coordinated and non-dative uses. Add 71 regression cases and document the Portuguese grammar sources in both READMEs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Tested directly on the latest SubtitleEdit/plugins main plus these changes: 3,885 passed, 7 skipped, 0 failed, including native Avalonia UI tests under Xvfb. Existing duplicate xUnit data warning remains.
Published the upstream-based self-contained linux-x64 version 1.6.0 successfully.
Verified the corresponding implementation through the published binary in graphical normal mode and headless batch mode, including name-choice reuse without an external .NET runtime.
Compared complete episode outputs against prior published behavior and checked preservation of source subtitles and cue timings. For the new ferrar rule, all 941 cues were compared: exactly two appropriate slang changes, with cue numbers, timings and original file hashes unchanged. Added 39 regression cases, including inflections, markup/case, idempotence, formal address, disabled rules and literal-use guards.
Added 71 dative-recipient regression cases. Compared all 830 cues of an additional episode through the published self-contained binary: exactly three appropriate indirect-object corrections, including the reported negative question. Cue numbers/timings and original subtitle hashes remain unchanged. The updated upstream v1.6.0 self-contained linux-x64 publish also succeeds.
Distribution
Please review and merge into the public plugin repository. The previous PR in the separate development repository was closed in favor of this upstream submission. Container-specific mounts/persistence were not directly tested; the image supplied by the user is linux/amd64, matching linux-x64.