Skip to content

BrazilianToEuropeanPortuguese v1.6.0: grammar fixes and personal name articles - #359

Merged
niksedk merged 3 commits into
SubtitleEdit:mainfrom
SMAP-git:ptpt-v1.6.0-name-articles-grammar
Nov 9, 2026
Merged

niksedk merged 3 commits into
SubtitleEdit:mainfrom
SMAP-git:ptpt-v1.6.0-name-articles-grammar

Conversation

@SMAP-git

@SMAP-git SMAP-git commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Update the public BrazilianToEuropeanPortuguese plugin from 1.5.0 to 1.6.0.
  • Add accumulated general-purpose contextual vocabulary, orthography, clause-agreement and reference-driven conversion fixes. Rules are not tied to a particular film or series.
  • Fix noun-subject direct-object and reflexive clitic placement, reference-confirmed informal agreement after opening adverbs, first-plural clitics, sports vocabulary and supported purpose clauses.
  • Add an editable personal-name article list shared by preview and Batch convert. Normal preview optionally asks once per unresolved relevant name; batch processing remains entirely unattended/headless.
  • Generate native executable manifests on self-contained publishes, avoiding an external .NET runtime requirement in Docker installations.
  • Update English and PT-PT documentation and regression tests. Preserve current upstream documentation and screenshot removal.
  • Convert qualified Brazilian informal ferrar to European lixar across conjugations, personal clitics and reviewed abstract objects (Ferrei tudo → Lixei tudo; estou ferrado → estou lixado). English screw up/over can resolve additional senses. Preserve literal and unresolved uses, respect vocabulary settings/local overrides, and document Priberam references.
  • Extend neutral a + personal-pronoun recipients to dative clitics, reusing the existing para-recipient rule: Não contou a ela? → Não lhe contou?, Contei a elas → Contei-lhes, Dei a ela tudo → Dei-lhe tudo. Cover supported verb families/tenses, infinitives, negative/subordinate clauses and reviewed intervening direct objects; preserve emphasized/coordinated recipients and non-dative senses. Document Ciberdúvidas grammar sources in both READMEs.
  • No source subtitle files, generated binaries or unrelated plugins are included.

Validation

  • Tested directly on the latest SubtitleEdit/plugins main plus these changes: 3,885 passed, 7 skipped, 0 failed, including native Avalonia UI tests under Xvfb. Existing duplicate xUnit data warning remains.

  • Published the upstream-based self-contained linux-x64 version 1.6.0 successfully.

  • Verified the corresponding implementation through the published binary in graphical normal mode and headless batch mode, including name-choice reuse without an external .NET runtime.

  • Compared complete episode outputs against prior published behavior and checked preservation of source subtitles and cue timings. For the new ferrar rule, all 941 cues were compared: exactly two appropriate slang changes, with cue numbers, timings and original file hashes unchanged. Added 39 regression cases, including inflections, markup/case, idempotence, formal address, disabled rules and literal-use guards.

  • Added 71 dative-recipient regression cases. Compared all 830 cues of an additional episode through the published self-contained binary: exactly three appropriate indirect-object corrections, including the reported negative question. Cue numbers/timings and original subtitle hashes remain unchanged. The updated upstream v1.6.0 self-contained linux-x64 publish also succeeds.

Distribution

Please review and merge into the public plugin repository. The previous PR in the separate development repository was closed in favor of this upstream submission. Container-specific mounts/persistence were not directly tested; the image supplied by the user is linux/amd64, matching linux-x64.

SMAP-git and others added 3 commits November 9, 2026 00:29
Generalize contextual vocabulary, clause agreement, clitic placement and reference-driven corrections. Add editable name article settings and preview-only automatic questions while preserving headless batch conversion. Emit native executable manifests for self-contained publishes and update bilingual guides and regression tests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Cover conjugated harmful slang, personal clitics, abstract objects and reference-confirmed uses while preserving literal and unresolved senses. Add regression tests and bilingual dictionary-grounded documentation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Extend the existing recipient conversion beyond para to a, reuse clitic placement across supported tenses and contexts, and handle reviewed intervening objects. Preserve emphasized, coordinated and non-dative uses. Add 71 regression cases and document the Portuguese grammar sources in both READMEs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@niksedk
niksedk merged commit 2cf3ee7 into SubtitleEdit:main Nov 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants