Skip to content

Add the hidden Blood Magic path - #71

Merged
XxFran10xX merged 69 commits into
mainfrom
feat/bloodmagic-progression
Nov 15, 2026
Merged

XxFran10xX merged 69 commits into
mainfrom
feat/bloodmagic-progression

Conversation

@XxFran10xX

@XxFran10xX XxFran10xX commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Status record

  • Reviewed: Fable 5.2 CHANGES REQUESTED at 54358f0, fixed in 7c2d884, re-review APPROVE at 7c2d884
  • Second opinion: CodeRabbit skipped (116 files > 100); Opus 5.5 APPROVE at ebf26d7; its cheap minors fixed in 1e980a9
  • Dev-tested: at 1e980a9 (TFMCDev01 02:23 UTC: clean load, altar placed, room corrupted with the new level-0 look; later commits are tests only)
  • Local tests: blood 213/213 at 664d769; coverage back to 100% (b150b9f + 664d769)

What

Adds the hidden Blood Magic path to Magic (package net.tfminecraft.magic.blood, config folder wildmagic/bloodmagic/). Hidden content: keep it off the wiki. It ships switched off (enabled: false): a server turns it on by hand.

  • Voices. A hidden whisper meter fills from dark deeds: blade kills of animals, permanent character kills, deep corruption, robbing (RPCharacters' evil RP play event, once per session), and faster with the Occultist trait. Lorveor, the Bloodfather, then teaches the path and gives a bound ritual knife and altar. Voices reach the mage only when alone before an altar stands, and only in its chamber after. Staff can wake them with /magic blood whisper.
  • Altar.
    • Placing it: underground only, outside WorldGuard regions, and claim plugins are asked first (at the corners of the whole locked area) through a BlockPlaceEvent.
    • Defenses: it can't be broken, pushed or blown up, and liquids never flow into its chamber.
    • Corruption: the room reddens over 6 levels (redstone veins, netherrack, red bricks, crimson flesh, wart), journalled so purification restores it, never inside protected regions. Re-turning a block costs no budget, so a full room still deepens.
    • Purifying: it purifies itself when the owner character dies.
  • Animal stage. Bind another player's animal on the altar with the ritual knife and kill it with that knife. 7 kinds, one per 24 hours. A stolen animal leaves a trace and a delayed note for its owner; a drained pack animal still drops its saddle, armour and chest.
  • The Bloodfather's question. Two answers:
    • Kneel (devotee): the hidden Manaless trait, the hidden Bloodsworn class (through RPCharacters ClassUnlocks), bound armour, then straight to the finals.
    • Kneel to no one (true path): the hunt.
  • Hunt and finals.
    • Hunt: sacrifice knocked-out characters on the altar (always a permanent kill) for 7 points, scored by a hidden closeness ranking built from RP conversations, time spent near each other and the will heir. That unlocks the Sanguinar class and armour, each piece named after a victim (Skull, Ribcage, Hide, Shinbones of ).
    • Finals: the 5 closest characters, named one at a time from least close to closest; the named one stays named. A target dying any other way is a failed sacrifice: backlash and a 72-hour wait. Each final gives class rewards and, on the true path, stat boons.
    • Anti-abuse: same account never counts, minimum playtime and character age, and the same player never twice in a row during the hunt.
  • Artefacts, pool and resonance. Path artefacts charge in the altar's pool; a heartbeat meditation draws their charge into blood resonance, which gates the blood spells by tier.
  • Carry. Sneak and right-click a knocked-out character with the blood knife to drag the body along (RPCharacters moveDowned); it is never laid in liquid, fire or walls.
  • Effects. BloodFx gives every moment layered, configurable sounds and particles (fx.yml).
  • Path permissions. permissions: gives the played character of each path a permission (magic.blood.bloodsworn, magic.blood.sanguinar) that follows the character. ArmourShop uses it for the Bloodsworn skins.
  • Staff tools. /magic blood list | info | stage | path | give | whisper | voice | target | bonds | altar | pool | reset, documented in ADMIN-COMMANDS.md.

Depends on

Notes

  • Act System caps for the two classes are in ACT-SYSTEM.md (11 in Act 1).

🤖 Generated with Claude Code

XxFran10xX and others added 14 commits October 25, 2026 11:30
Blood magic phase 1: per-character blood records and altars kept in memory and written
whole, bound altar/knife items, a barrier-block altar with a level-based display that
nobody can break, push or blow up, placement only underground and outside WorldGuard
regions, self-purification when the owner character dies, and /magic blood staff tools.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Blood magic phase 2: dark deeds (blade animal kills, more at night or alone; characters you
killed for good; deep corruption) fill a hidden per-character meter, faster for configured
evil traits. Past the threshold the god teaches the rite in order and hands over the bound
ritual knife and altar. Later stages hear occasional lines; true-path mages only hear their
own dark self, in a different style and sound. Staff can wake the voices or push a line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Blood magic phase 3: the ritual knife binds a living animal still on its owner's altar and
only that knife's kill counts. Seven kinds, one per rolling day, taken from other Cooking
husbandry keepers (read by reflection, so Cooking stays optional). Each offering raises the
altar's level and look and corrupts the room a little; the room also turns slowly between
offerings. Every changed block is journalled and put back when the altar purifies. A stolen
animal leaves a trace where it was led away and a vague note for its keepers. The seventh
kind hands over the blood knife and moves the mage to the god's question.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Blood magic phase 4: right-clicking the altar with one's own blood knife opens the god's
question with a confirmation step. Devotees keep permanent injuries as their mark, skip the
hunt, unlock the devotee class (through RPCharacters' ClassUnlocks when present) and get
bound armour. Refusing keeps the current class and starts the hunt. Blood armour is
unbreakable, will not stay on any other character, and crumbles once its owner is dead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Blood magic phases 5 and 6: a knocked-out character near the altar is dragged onto it with
the mage's blood knife and dies for good when the short rite ends. Hunt sacrifices earn
points by how much the victim mattered to the mage, from a hidden bond score: counted RP
conversations, time spent near each other (sampled for every character) and a will heir who
is another player's character the two spent real time with. Same-account characters never
count; fresh characters and taking the same player twice in a row are refused. The closest
characters are kept for the finals, named one at a time from least close to closest. A named
target dying any other way is a failed sacrifice with backlash and a wait; dead, vanished or
long-absent targets are replaced, and staff can list, reroll, set or skip targets. Finals
grant MythicLib stat boons; reaching the hunt goal unlocks the true class and armour.
Builds against RPCharacters 2.31.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sneak and right-click a knocked-out character with the blood knife to drag
the body along; RPCharacters keeps it down where it is moved (moveDowned),
so the rite now also holds the victim on the altar. The items, altar stages,
trace and the two bound armour sets use the tfmc_blood ItemsAdder pack, and
bound items opt out of ItemsAdder's auto_update.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BloodFx plays configurable moments (fx: in bloodmagic.yml): layered sounds
and particles in points, rings, columns and spirals, with delays and private
layers for the player the moment is about. Altars breathe by level while
someone is near; the rite, the drag, the question, the finals, the voices
and the armour all have their own.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The god speaks as a hungry choir ("we"), the dark self as the mage's own
cold thoughts ("I"); final target, nobody and failed lines now have one
version per voice. Rewrites the teaching lines, stage whispers, ascended
lines, every altar, rite and drag message, the question menu and the item
lore; unnamed stolen animals read "your cow".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The god is now Lorvear, the first vampire: paternal and regal, he calls the
mage child and speaks of Alaric, the Reaper and the Lady of the Tower, as in
the Codex. The question menu asks the mage to kneel to him or to no one; the
dark self answers to no father.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The self voice is the Void Reaper working on the mage unseen: at the god's
question it argues against kneeling half the time, and it is all a mage
hears after refusing Lorvear. It only hints at the quiet and the cold;
grey with a touch of void in its colour and effects.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- A victim who logs out on the altar is sacrificed as they leave.
- The no-repeat rule only applies to the hunt, so a named final target can
  always be taken; carrying needs the same eligibility as the rite.
- The rite needs a clear line from the body to the altar and refuses a
  body another mage is dragging; dragged bodies are never laid in liquid,
  fire or walls.
- Boons are removed by key, also on disable; the question menu acts a
  tick after the click.
- Bound animals are tagged so they always wake after an unload, a second
  mage cannot take a bound animal, and a refused teleport does not bind.
- Corruption skips protected regions; placing the altar fires a
  BlockPlaceEvent so claims can refuse it and loggers record it.
- enabled: false stops everything but the dead-owner sweep; corruption
  plants are fully grown; purifying clears the block the altar was.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Switching the feature off ends rites, drags and animal bindings, and a
  victim's logout only finishes a rite that still holds.
- Drag safety is judged at body height, so slabs, paths and soul sand are
  fine while water plants, waterlogged blocks and hot ground are not.
- The rite's line of sight runs a body's height up to the altar top, so
  slabs, pews and the altar's own bone blocks no longer block it.
- A refused move does not start a rite.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A second line just above slab height only counts full blocks, so a body
can no longer be pulled through a one-block window while slabs, stairs
and beds still do not get in the way.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0029d205-8d3b-4eba-8473-10adefb37b34
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added the size:XXL 1,000+ effective changed lines (tests excluded in mixed PRs). label Oct 25, 2026
XxFran10xX and others added 14 commits October 26, 2026 00:15
The true path's armour is made from the people it took: each piece with
a {victim} name in bloodmagic.yml is named after a hunt victim, the most
important (most points, then the closest rank) on the skull and so on
down to the boots. With fewer victims than pieces the names start over
from the top; an unknown victim leaves the item's own name.

Character sacrifices now keep the victim's closeness rank so the order
can tell victims worth the same points apart.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
permissions: in bloodmagic.yml names a permission each path's character
holds while it is played (magic.blood.bloodsworn, magic.blood.sanguinar),
so ArmourShop can show the Bloodsworn skins only to Bloodsworn. It
follows the character: set on session start, the choice and staff
path/reset, removed on session end and quit.

ArmourShop skins replace a piece's ItemsAdder compound and drop its
override_auto_update, so blood armour is marked again whenever an
inventory closes, armour changes or a session starts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
permissions: in bloodmagic.yml takes one permission or a list, so a
Bloodsworn character can hold both magic.blood.bloodsworn (its skins)
and magic.wild (the hidden Wild Mage Sets skin category).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The binding mage's own ritual knife now kills a bound animal with one
hit (the hit is made lethal at HIGHEST), with a new animal_slain moment:
a sweep, a wet strike and a spray of blood. Any other hit keeps its
damage, on people too.

The Ritual Knife is now an MMOItems lore weapon (m.lore_weapons.ritual_knife),
so its name, lore and look come from MMOItems. The voice's first lines
no longer name Lorvear: only small hints, like Alaric.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Redstone ore and dust, netherrack and nether bricks, crimson nylium, roots,
fungus and weeping vines, nether wart blocks and red candles; no more
cobwebs, wither roses, skulls, mossy or cracked stone or bone blocks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bloodmagic.yml and the blood: block of messages.yml become one folder,
wildmagic/bloodmagic, with a file per topic: settings, items, voices,
animals, corruption, choice, armour, fx and messages. Every .yml there
but messages.yml is merged into one config; messages.yml is laid over
Magic's messages (live keys first, its bundled copy as fallback). A
leftover bloodmagic.yml is reported and no longer read. wildmagic/ is
meant to take the other wild schools the same way.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Breaking, pushing or blowing up a block the altar changed (while it is
still what the altar made it) fails like the altar itself: a warm pulse,
a heartbeat and a short line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The altar is the middle of a meditation circle, so placing it shapes the
room around it: open floor out to the farthest pedestal (9 by 9 with the
default offsets), placement.room.height high. Small gaps are carved and
floor holes filled with the stone the player stands on; too many changes,
liquid, containers, unbreakable blocks, another altar or its changes,
claimed ground or opening the rock to the sky refuse the stone with the
size it needs. Runs after the protection probe; the room stays when the
altar is purified.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The altar is the middle of its meditation circle: its owner right-clicks
it with an empty hand and sits on top (an invisible, unsaved display),
so meditation starts there like on any seat. The seat goes when left,
when the altar is purified and when Magic stops.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…fting colours

Right-clicking the altar no longer seats its owner: sitting on it (GSit /sit or any seat
on top) is how they meditate there, and the stone answers with its own line (a colder
one for anyone else). The plugin-made seat is gone.

From the knife on, the mage's own thoughts answer Lorvear half the time. Animal lines
are written from early to late and the pick follows the kinds given. Each voice now has
a start and an end gradient (voices.yml colors) blended by how far the character has
come: Lorvear grows from dim red into the bright Bloodmagic reds, the mage's own voice
from pale and clear into dark blood. Messages written as {god}... or {self}... (the
animal and rite reactions) are said in those colours. No line names another god or
order any more.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Placing the altar puts an InteractibleFurniture pedestal on every free spot of its
meditation ring (open, on solid floor; taken spots are left for the player's own). They
belong to the altar: nobody can pick them up, carry them off or break them. Purifying the
altar removes them and drops whatever sits on them; pedestals that are not loaded then
stay bound in data/bloodmagic/leftover_pedestals.json and go when their chunk loads.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
XxFran10xX and others added 10 commits October 27, 2026 21:23
fran: devotees get their class rewards but no stat boons.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sanguinar has no mana, so final 2 gives 2 max health instead of 20 max mana.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each path now sets out 8 bound artefacts on its altar's pedestals when its
class is given: the devotee's at the kneel, the true path's when the hunt is
done, and each true-path final puts one named after its victim in place of
an older one. An artefact only counts once sunk into the altar's pool of
blood, and each gives an equal share of the path's blood resonance
(devotee 20, true path 20 rising to 95 with the finals).

Blood spells now need that resonance for their tier (Minor 5 up to
Transcendent 90); a refused spell costs nothing. The pool stays full while
the path goes on. Once it is complete, the sunk artefacts drink it by the
hour the character is played, and only people sacrificed on the altar fill
it again (by closeness, same rules as the hunt). Resonance never falls
below the Minor floor, and nothing earned is taken away.

Staff get /magic blood pool and give <player> artefacts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nance

Artefacts no longer sink into the pool for good. Right-clicking the altar
with one sets it in the pool to charge: it sinks, turns in the blood while
the stone's heart beats, and rises glowing back into its owner's hands to
set on a pedestal again. Charging is free while the path goes on and costs
pool blood once it is complete; an artefact still charging when its owner
leaves (or the server stops) comes back at the next session.

Blood resonance now comes from wild magic meditation: sitting on the altar
among the charged artefacts, a drop of blood rises from one with each
heartbeat and drifts to the mage, and catching it draws its charge, much on
the beat and a little off it (which also costs the mage some health). Once
the path is complete, resonance fades by a share of itself per hour played.
The meditation, the charging and the altar room each have a private sound
loop (vanilla placeholders until the music is chosen).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fran picked the catacomb chant: tfmc_blood:meditate.chant loops every 24 s
while meditating and tfmc_blood:rite.charge plays as an artefact goes into
the pool (both in the ServerAssets blood pack). The altar room gets no
ambience, so BloodAmbience goes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Bond flushes (every ten minutes, one file per changed character, so dozens
  on a full server) are written on a background thread in order, from
  copies taken on the main thread; shutdown waits for them. A failed write
  is logged.
- Fading blood resonance is written every ten minutes and on shutdown, or
  at once when a tier slips, instead of every minute per mage. A record
  reset or forgotten meanwhile is not written back.
- A meditation writes its record once, when it ends, not on every catch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A shutdown that never saves the world can bring a purified altar's chunk
back from before the purify: its display, altar block and glow return with
no altar behind them. Strays were only swept as chunks loaded, which misses
spawn and force-loaded chunks that load before the plugin. Settling after
enable now sweeps every loaded world too, and a stray whose altar is gone
also takes the altar block and glow under it (unless another altar stands
there).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…f as often

Sitting on a blood altar also ran Magic's own meditation start check every
tick: the altar's pedestals form a full ring, so it re-read the lore of all
eight blood artefacts each tick (about 0.06 ms per sitter) and could tell a
blood mage there were no artifacts. Blood altar seats are now skipped.

The charging artefact and the meditation drops move every other tick with
a two-tick teleport duration, halving their teleport events.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Kneeling no longer gives two random permanent injuries: the devotee gets
the one RPCharacters trait choice.devotee_trait names (manaless: -2 to every
attribute, given only here), and while a character bears it Magic takes
away all max mana (a -100% MAX_MANA modifier under the boons' key).

A character dying on the altar now hears it happen: four lines spread over
the rite (blood.rite.dying.1-4), one as it ends (dying.last), and another
if the rite breaks first (spared).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
XxFran10xX and others added 10 commits November 11, 2026 14:20
Lorveor the Bloodfather (not Lorvear/Blood Father), never living below or in
the stone; Alaric Thorme; fran's picks from the blind Fable/Opus test for the
victim's dying lines, the first whispers and the question; 24 further lines
improved where both models or Fable's blind judging agreed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…vate marks

Merged review by Opus and Fable 5.2: one question moment (the first never
played), no Warden/sculk particles, amber embers only for Lorveor, heartbeats
in three pitch bands, a slowing heart for the final sacrifice, backlash marks
private, no damage hearts in rites, calmer corruption palette (no netherrack
or nylium, crimson hyphae at level 3), all four candles to the last level, and
tfmc_blood sound events with neutral subtitles for the voices and rites.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…stals, glowing drops, following music

- FX layers take chance (0-1) and jitter (random extra ticks), so the altar ambience drips at random
  moments instead of every 3 s on the dot; only the level 5 heart keeps a steady beat.
- The altar's pedestals are still placed at once but come up out of the floor one after another,
  5 ticks apart, with a scrape that climbs in pitch and a little floor dust.
- Meditation drops face the mage, are lit full bright, and swell smoothly up to the beat and ease
  back after it (display interpolation) instead of snapping.
- The rite, question and meditation music is bound to the mage so it follows them; meditation music
  is on the records slider like the other two (category configurable) and loops by the wall clock.
- Test players hear entity-bound sounds and test displays keep billboard/brightness (MockBukkit leaves
  both unimplemented), so the music tests run instead of being skipped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
meditation.drops.item is now ia.tfmc_blood:meditation_drop (ServerAssets ef05514); redstone stays the
fallback when the item is missing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
EvilPlayWhispers listens for RPCharacters' EvilRpPlayEvent (robbing, pickpocketing, lockpicking,
looting a locked grave, reported by Thievery) and adds sources.robbery (4) to the current
character's whisper meter when the play starts a new evil RP session, so restarting a lockpick can't
farm it. The event is registered by name, so Magic still runs against an RPCharacters without it
(it logs once). Permanent kills already count (character_kill 15); knockouts never did.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… the victim

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ns faster and deeper

- Voices, a final target's naming and a failed sacrifice's backlash reach the mage only in their
  altar's chamber once it stands, and before that only when nobody is near. Naming and backlash wait
  (pendingNaming/pendingBacklash) until then. Lines every 10-25 minutes.
- Corruption: bigger budgets (24 at level 0 up to 300, about the whole chamber), 15 blocks per
  sacrifice, 3 every 10 minutes. Each level is redder (redstone veins, netherrack and cracked bricks,
  red bricks, crimson hyphae, wart); rules get max_level so early looks retire, later rules also take
  what earlier ones made, and re-turning a block costs no budget, so a full room still deepens.
- Placeholder notes dropped from the boons, class rewards and pool.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s keep their load

- settings.yml ships enabled: false, so a Magic update never opens the path on a server by itself.
- The named final target stays first when closeness reorders the rest (no swap mid-rite).
- The claim check probes the corners of the whole locked area, not just the room.
- Drained pack animals still drop their saddle, armour, chest and its contents.
- Bond writes on unload go through the single background chain; a reload waits for it.
- Liquids never flow into a locked chamber; floor decorations are never solid (no wart blocks).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ld live config

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@XxFran10xX
XxFran10xX marked this pull request as ready for review November 15, 2026 01:48
@XxFran10xX

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Action not completed

Review skipped: 116 files exceed the limit of 100.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

XxFran10xX and others added 4 commits November 15, 2026 02:55
…shed stubbing)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tests for the gaps from the recent blood commits: liquids stopped at the
chamber and blasts sparing its walls, corner claims refusing the altar,
purifying an altar in an unloaded world, what a sacrificed animal carried
(inventory, pack chest, worn armour), the voices waiting during a rite and
an altar gone as the rite ends, the question ending when the mage can no
longer answer and speech outside the god's wait, one-shot and absent
question music, finals checks out of the voices' reach, pedestals rising
without a transformation, after removal or without the plugin, malformed
candle wicks and the default spawner, solid corruption decorations, room
template, choice line and meditation sound edge cases, pending naming in
BloodRecord.isEmpty, single-stop voice gradients, end-only voice colours,
near-certain FX chances and the evil-play listener ignoring other events.

Two branches were unreachable, so their expressions are simplified with
no change in behaviour:
- FinalService.refill: targets.remove(named) was always true (named is
  the list's first element and the list only grows before it), so the
  guard is now just named != null.
- BondService.unload: minutes != null was always true when the key was
  dirty (add() fills MINUTES and DIRTY together), so the check is dropped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… the blood boons

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…erage)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@XxFran10xX
XxFran10xX merged commit 4b93776 into main Nov 15, 2026
3 checks passed
@XxFran10xX
XxFran10xX deleted the feat/bloodmagic-progression branch November 15, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant