chore(oxlint.config): enable 'vitest-js/no-conditional-in-test' outside type tests by sukvvon · Pull Request #12256 · TanStack/query

sukvvon · 2026-10-21T12:50:24Z

🎯 Changes

Enable vitest-js/no-conditional-in-test in the root test override, so runtime test bodies always take the same path instead of branching with if.

The JS plugin version is used because it only reports conditionals in the test body itself. The native rule also reports the conditionals in components and query functions defined inside tests.
Turn the rule off for *.test-d.ts* files, since type tests narrow results with if to check the type of each state.

No runtime test has such a conditional today, so there is nothing to fix.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Improved test code validation by enabling checks for conditional test logic and valid expectations.
- Preserved support for conditional narrowing in type declaration tests.

…de type tests

changeset-bot · 2026-10-21T12:50:31Z

⚠️ No Changeset found

Latest commit: 25a4884

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-10-21T12:50:49Z

View your CI Pipeline Execution ↗ for commit 25a4884

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	5m 15s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	38s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-21 12:59:28 UTC

github-actions · 2026-10-21T12:51:16Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

…tional-in-test # Conflicts: # oxlint.config.ts

coderabbitai · 2026-10-21T12:52:40Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 243c04db-ef34-4227-9716-0820d1a413bd

📥 Commits

Reviewing files that changed from the base of the PR and between d8fbf7e and 25a4884.

📒 Files selected for processing: 1

oxlint.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The Oxlint test-file override enables two Vitest rules as errors. A separate type-test override disables conditional-test enforcement.

Changes: Test lint configuration

Layer / File(s)	Summary
Configure conditional-test linting `oxlint.config.ts`	Test files enable `vitest-js/no-conditional-in-test` and `vitest-js/valid-expect` as errors. Type-test files disable `vitest-js/no-conditional-in-test`.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Suggested reviewers: dogpawhat

Merge Risk: ⚪ Minimal · up to 25a48

No actionable merge-blocking risk was identified in this test-lint configuration change.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly identifies the main change: enabling `vitest-js/no-conditional-in-test` outside type tests.
Description check		The description explains the rule changes, the reason for the JavaScript plugin, the type-test exception, test status, checklist items, and release impact.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-21T12:52:47Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12256

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12256

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12256

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12256

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12256

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12256

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12256

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12256

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12256

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12256

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12256

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12256

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12256

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12256

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12256

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12256

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12256

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12256

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12256

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12256

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12256

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12256

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12256

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12256

commit: 25a4884

github-actions · 2026-10-21T12:56:33Z

size-limit report 📦

Path	Size
react full	11.76 KB (0%)
react minimal	8.59 KB (0%)

chore(oxlint.config): enable 'vitest-js/no-conditional-in-test' outsi…

05a175f

…de type tests

sukvvon self-assigned this Oct 21, 2026

Merge remote-tracking branch 'origin/main' into chore/oxlint-no-condi…

25a4884

…tional-in-test # Conflicts: # oxlint.config.ts

sukvvon merged commit 914eef7 into main Oct 21, 2026
9 checks passed

Navigation Menu

Repository navigation

chore(oxlint.config): enable 'vitest-js/no-conditional-in-test' outside type tests - #12256

chore(oxlint.config): enable 'vitest-js/no-conditional-in-test' outside type tests#12256
sukvvon merged 2 commits into
mainfrom
chore/oxlint-no-conditional-in-test

sukvvon commented Oct 21, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 21, 2026 •

edited

Loading

Uh oh!

nx-cloud Bot commented Oct 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

coderabbitai Bot commented Oct 21, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 21, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 21, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 21, 2026 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Oct 21, 2026 •

edited

Loading

nx-cloud Bot commented Oct 21, 2026 •

edited

Loading

coderabbitai Bot commented Oct 21, 2026 •

edited

Loading

pkg-pr-new Bot commented Oct 21, 2026 •

edited

Loading