Skip to content

build(max2w3d): Fix the compile error from passing no image size to Targa::SetImage - #3696

Open
xezon wants to merge 1 commit into
TheSuperHackers:mainfrom
xezon:xezon/fix-max2w3d-compile-error
Open

xezon wants to merge 1 commit into
TheSuperHackers:mainfrom
xezon:xezon/fix-max2w3d-compile-error

Conversation

@xezon

@xezon xezon commented Nov 17, 2026

Copy link
Copy Markdown

WWLib's Targa::SetImage takes the size of the image buffer, which max2w3d's removed copy did not. The exporter now passes the size of its material color texture buffer.

…arga::SetImage

WWLib's Targa::SetImage takes the size of the image buffer, which max2w3d's removed copy
did not. The exporter now passes the size of its material color texture buffer.
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker CompileBug Bug at compile time Build Anything related to building, compiling Tools Affects Tools only labels Nov 17, 2026
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Export_Geometry now passes sizeof(imageBuffer) to Targa::SetImage when assigning the generated image buffer.

Changes

Targa export

Layer / File(s) Summary
Pass image buffer size
Core/Tools/WW3D/max2w3d/w3dexp.cpp
Export_Geometry now supplies sizeof(imageBuffer) to Targa::SetImage.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: bobtista, mirelle7, skyaero42

Merge Risk: Minimal · up to 431e6

This change fixes a build error in the max2w3d exporter by passing the image buffer size to Targa::SetImage. No concrete risk was identified, and it is ready to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the actual change: passing the image buffer size to Targa::SetImage in max2w3d to fix a compile error. It matches the single-line change in w3dexp.cpp. The 'build(max2w3d):' prefix is …
Description check Passed The description states that WWLib's Targa::SetImage needs the image buffer size, which the removed max2w3d copy did not pass. It also states that the exporter now passes the size of its material color…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the actual change: passing the image buffer size to Targa::SetImage in max2w3d to fix a compile error. It matches the single-line change in w3dexp.cpp. The 'build(max2w3d):' prefix is a conventional scope label and does not affect accuracy.

Full details: Description check

Explanation

The description states that WWLib's Targa::SetImage needs the image buffer size, which the removed max2w3d copy did not pass. It also states that the exporter now passes the size of its material color texture buffer. This matches the summarized change in Export_Geometry.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5a8a0834-8ff9-4f15-981d-2863b5c17dfc
Commits

Reviewing files that changed from the base of the PR and between 519c261 and 431e651.

Files selected for processing: 1

  • Core/Tools/WW3D/max2w3d/w3dexp.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This change appears safe to merge.

Summary

Fixes the missing image-size argument in the 3ds Max W3D exporter.

  • The geometry exporter now passes the size of its color image buffer.

No actionable issues found. Build and runtime tests were not run.

Reviews (1) · Last reviewed commit: "build(max2w3d): Fix the compile error fr..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Anything related to building, compiling CompileBug Bug at compile time Minor Severity: Minor < Major < Critical < Blocker Tools Affects Tools only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant