Skip to content

Upgrade Pyrefly and initialize validator response fields #3772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamtheturtle wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Upgrade Pyrefly and initialize validator response fields #3772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
58da743
Upgrade Pyrefly to 1.4.0
adamtheturtle Oct 19, 2026
5b12521
Initialize validator response fields in base constructors
adamtheturtle Oct 19, 2026
62309c1
Keep live CI jobs on distinct Vuforia credential slots
adamtheturtle Oct 19, 2026
ff98b5b
Merge commit 'cc69e534c2fedead3e56f2f124b27b323dd07065' into HEAD
adamtheturtle Oct 21, 2026
80aca73
Queue Vuforia workflows instead of replacing pending tests
adamtheturtle Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ on:

# We share Vuforia credentials and therefore Vuforia databases across
# workflows. We therefore want to run only one workflow at a time.
concurrency: vuforia_credentials
# Queue pending runs so updates to other PRs do not cancel their tests.
concurrency:
group: vuforia_credentials
queue: max

permissions: {}

Expand Down Expand Up @@ -125,13 +128,14 @@ jobs:
- tests/mock_vws/update_target/test_update.py
- tests/mock_vws/update_target/test_width.py
- tests/mock_vws/update_target/test_inactive_project.py
# Live jobs must keep distinct credential indices below 100.
- tests/mock_vws/model_target_web_api
- tests/mock_vws/vumark_generation_api
- tests/mock_vws/test_model_target_generation_failure.py
- tests/mock_vws/test_model_target_generation_warning.py
- tests/mock_vws/test_model_target_failure_response.py
- tests/mock_vws/test_model_target_training_allowance.py
- tests/mock_vws/model_target_web_api
- tests/mock_vws/test_model_target_retries.py
- tests/mock_vws/vumark_generation_api
- tests/mock_vws/test_vumark_generation_failure.py
- tests/mock_vws/test_target_validators.py
- tests/mock_vws/requests_mock
Expand All @@ -142,6 +146,7 @@ jobs:
- tests/mock_vws/test_docker.py
- README.rst
- docs/
- tests/mock_vws/test_validator_errors.py

steps:
- uses: actions/checkout@v7
Expand Down
4 changes: 3 additions & 1 deletion prek.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@ hooks = [
{
id = "actionlint",
name = "actionlint",
entry = "uv run --group=dev actionlint",
# actionlint does not yet recognize GitHub's concurrency.queue key.
# Remove this exact diagnostic filter when rhysd/actionlint#657 is fixed.
entry = "uv run --group=dev actionlint -ignore 'unexpected key \"queue\" for \"concurrency\" section'",
language = "python",
pass_filenames = false,
types_or = ["yaml"],
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ dev = [
"pylint-per-file-ignores==4.0.0",
"pyproject-fmt==2.30.3",
"pyprojroot==0.3.0",
"pyrefly==1.3.2",
"pyrefly==1.4.0",
"pyright==1.1.414",
"pyroma==5.0.1",
"pytest==9.1.1",
Expand Down
Loading
Loading