[Nic-dorman]

Summary

Three e2e files claimed payment and live-network coverage that their tests don't provide (V2-1809, from the ant-node CI audit V2-1799).

• tests/e2e/complete_payment_e2e.rs: 16 lines of docs describing a full quote → median → pay → store → retrieve flow, and no tests. Deleted, with its mod line.
• tests/e2e/live_testnet.rs: three #[ignore] tests whose bodies are unimplemented!() (run_load_test, run_verify_chunks, run_comprehensive_data_tests). Deleted, with its mod line.
• scripts/testnet/load-test.sh, churn-verify.sh, run-data-tests.sh: each one's only job was to cargo test … --ignored one of those three stubs. Deleted. Nothing else references them.
• tests/e2e/payment_flow.rs: the header listed quote collection, median pricing, payment caching and node-failure resilience. Its only test checks that the network starts, a funded wallet can be created and node 0 exists. The header now says exactly that and points at what does cover the flow today: security_attacks.rs and merkle_payment.rs for the rejection paths, and the ignored five-node test in tests/webrtc_direct_devnet.rs for a single paid upload. The missing full-flow test is tracked as V2-1841.

No test that ran before stops running: the deleted tests were either absent or unimplemented!() behind #[ignore].

Linear issue

Closes V2-1809

Risk tier

• T0 — docs / tooling / CI / pure UX-output. Repo CI only.
• T1 — client-only, no network-facing behavior change. CI + prod compat smoke.
• T2 — node/client logic with behavioral surface, no protocol/format/economics change. Dev testnet + ADR.
• T3 — protocol / storage format / payments / routing. T2 evidence + adversarial testing.

Compatibility

• Wire: none
• Storage: none
• API: none. Test code (tests/e2e/) and three testnet scripts only.

Semver impact

• breaking
• feature
• fix

Test evidence

On dev2 (Linux), at this commit on top of main 360d472:

• cargo fmt --all -- --check: clean.
• cargo +stable clippy --all-targets --all-features -- -D warnings: clean.
• cargo test --features test-utils --test e2e payment_flow: 1 passed (28.9 s; 10 nodes + Anvil).
• cargo test --features test-utils --test e2e -- --list: 121 tests. Main lists 124, and the 3 missing are the deleted #[ignore]d unimplemented!() stubs, so CI's e2e run goes from 121 passed / 3 ignored to 121 passed / 0 ignored.

New dependency

none

ADR

n/a

Mitigation / rollback

Revert the commit; it only touches test files and scripts.

🤖 Generated with Claude Code

[MaidSafe-Hermes]

APPROVE. Both seats agree (two model families): 2/2 seats reviewed (sol-1 gpt-6.1-sol xhigh; glm-1 z-ai/glm-5.3).

The removed Rust files contain no executable payment test and three ignored unimplemented!() tests; the deleted scripts invoke only those stubs. The module declarations are removed with the files. I checked the full PR-head tree: no remaining references to the deleted script paths or test names. payment_flow.rs now accurately labels its test as setup-only; the referenced ignored five-node paid-upload test exists in tests/webrtc_direct_devnet.rs. All current PR checks pass.

No blocking defect found. The full quote-to-payment, storage, and cross-node retrieval flow remains a tracked coverage gap (V2-1841), not a regression introduced here.