Repository navigation
Symfony 8 : monte tiime/newrelic-bundle en v2 - #2452
Open
BySplashGm wants to merge 1 commit into
Open
BySplashGm wants to merge 1 commit into
BySplashGm wants to merge 1 commit into
Conversation
BySplashGm
requested review from
Mopolo,
agallou and
stakovicz
as code owners
November 6, 2026 14:07
stakovicz
approved these changes
Nov 6, 2026
Korbeil
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Étape 2 de #2441.
Contexte
tiime/newrelic-bundle1.0.x bloque la montée en Symfony 8 : il exigesymfony/http-kernel(etconfig,console,dependency-injection,event-dispatcher) en^5.4|^6.4|^7.0. La v2.0.0 ajoute le support de Symfony 8 tout en gardant la 7.4, on peut donc la monter dès maintenant.Modifications
composer.json:tiime/newrelic-bundle^1.0→^2.0.composer.lock: seul le bundle change (v1.0.3→v2.0.0), aucune autre dépendance n'est mise à jour.Ce que contient la v2 (diff v1.0.3...v2.0.0) :
php: ^8.4etsymfony/*: ^7.4|^8.0. Le projet est en PHP>=8.5et Symfony 7.4, donc compatible ;src/, seulement du nettoyage : closuresstaticdansConfiguration,readonlyet constantes typées dansNotifyDeploymentCommand. Les clés de config ne changent pas.Rien à modifier dans
config/packages/tiime_new_relic.yamlni dansconfig/bundles.php.Tests
Admin/Tresorerie/DevisFactures.feature, qui échouent déjà sur master.DevisFacturesinstable en local, aussi sur masterSur Mac ARM,
bin/bdi detect driversne sait pas télécharger chromedriver (Downloader for chromedriver arm64 is not implemented), donc tous les scénarios@javascriptéchouent dès le login. Une foischromium-driverinstallé dans le conteneurapachephptest, le scénario reste instable. J'ai lancéDevisFactures.feature8 fois de chaque côté :Les erreurs sont les mêmes des deux côtés, sur la même étape
I am logged in as admin and on the Administration:StaleElementReferenceException,There is no element matching XPath "//html"etResponseTextException. L'écart entre 6 et 4 sur 8 runs relève du bruit, et le code du bundle ne change pas de comportement entre les deux versions.Hors périmètre
AuthContext::iAmLoggedInWithTheUserAndThePassword()vérifie la page juste aprèspressButton('Se connecter'), sans attendre la fin de la redirection. Le retry ajouté dans Migre l'entité Ting TicketType vers Doctrine #2411 ne protège queclickLink('Administration')contreStaleElementReferenceException. Correctif possible : retenter aussiassertPageContainsText('Espace membre')sur les trois exceptions ci-dessus. Je peux le faire dans une PR séparée.