Repository navigation
PROD-3113: preflight previews the children of a skipped parent as skips, not failures (1.3.1-beta.2) - #268
Merged
Conversation
…ps, not failures On a fresh target, preflight skips pages whose page template the run would create first. The parent-not-on-target check then reported their children as failures, so the preflight ended "completed with errors" for a sync that would succeed. In preflight, children of a skipped parent are now skips; children of a failed parent are still failures. Bump to 1.3.1-beta.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jules-exel
approved these changes
Nov 10, 2026
This was referenced Nov 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #265–#267 (PROD-3113), found in the 1.3.1-beta.1 publish gate.
Problem
On a fresh target, preflight skips pages whose page template doesn't exist yet ("missing page template"), because the template is only created during the real run. The parent-not-on-target check from #265 then reported those pages' children as failures ("isn't on the target, because it failed or was skipped…"), so the preflight ended "✗ Sync completed with errors" even though the real sync succeeds (in the gate run, the real sync then put all 4 pages on the target with 0 failures).
Fix
processSitemap'sblockDescendantstakes a reason (missing|conflict|preflightSkip):Version
Bumps to
1.3.1-beta.2(beta.1 was never published; its gate failed on a leased target whose Fetch API returned no content or pages).Tests
Two new
process-sitemapcases (preflight skipped parent → skips; preflight failed parent → failures). Full suite: 2,821 pass.🤖 Generated with Claude Code