Skip to content

PROD-3113: preflight previews the children of a skipped parent as skips, not failures (1.3.1-beta.2) - #268

Merged
5PK merged 1 commit into
mainfrom
PROD-3113-preflight-skip
Nov 10, 2026
Merged

5PK merged 1 commit into
mainfrom
PROD-3113-preflight-skip

Conversation

@5PK

@5PK 5PK commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

Follow-up to #265–#267 (PROD-3113), found in the 1.3.1-beta.1 publish gate.

Problem

On a fresh target, preflight skips pages whose page template doesn't exist yet ("missing page template"), because the template is only created during the real run. The parent-not-on-target check from #265 then reported those pages' children as failures ("isn't on the target, because it failed or was skipped…"), so the preflight ended "✗ Sync completed with errors" even though the real sync succeeds (in the gate run, the real sync then put all 4 pages on the target with 0 failures).

Fix

processSitemap's blockDescendants takes a reason (missing | conflict | preflightSkip):

  • preflight, parent skipped → children are recorded and counted as skips: "skipped with its parent page "X" (source page N), which preflight skipped"
  • parent failed (preflight or real run) → children are still failures, as a real run would fail them too
  • parent in conflict → unchanged (skip + conflict entry)
  • real runs → unchanged

Version

Bumps to 1.3.1-beta.2 (beta.1 was never published; its gate failed on a leased target whose Fetch API returned no content or pages).

Tests

Two new process-sitemap cases (preflight skipped parent → skips; preflight failed parent → failures). Full suite: 2,821 pass.

🤖 Generated with Claude Code

…ps, not failures

On a fresh target, preflight skips pages whose page template the run would
create first. The parent-not-on-target check then reported their children as
failures, so the preflight ended "completed with errors" for a sync that would
succeed. In preflight, children of a skipped parent are now skips; children of
a failed parent are still failures. Bump to 1.3.1-beta.2.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@5PK
5PK merged commit afc0049 into main Nov 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants