[alan-agius4]

Follow-up to #34321:

• Combines buildPathWithParams and buildQueryWithParams into buildUrlWithParams.
• Reuses DefaultUrlSerializer from @angular/router for query parameter parsing and serialization instead of custom regex/encoding helpers.
• Adds fast-path checks to avoid regex/splitting and URLSearchParams instantiation when redirect targets do not contain placeholders.
• Applies joinUrlParts only to the path portion of redirect targets when prepending baseHref or X-Forwarded-Prefix so trailing slashes in query parameters or fragments are preserved.

[gemini-code-assist]

Code Review

This pull request refactors URL parameter resolution in Angular SSR by replacing buildPathWithParams and buildQueryWithParams with a unified buildUrlWithParams function that leverages Angular's DefaultUrlSerializer. It also optimizes route parameter replacement and prefix handling. Feedback on the changes points out a potential runtime TypeError when resolving path placeholders if a wildcard or positional placeholder refers to an out-of-bounds index, and suggests adding a fallback to 'undefined'.

[alan-agius4]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors URL and query parameter resolution in the Angular SSR package by consolidating buildPathWithParams and buildQueryWithParams into a single buildUrlWithParams function, and merging replaceRedirectParams into resolveRedirectTo. Feedback on these changes highlights two potential issues: first, appending url.search directly with + for relative redirects could result in malformed URLs with multiple ? characters if the target already contains query parameters; second, resolving path placeholders when fromPath has fewer segments than expected could pass undefined to joinUrlParts, leading to a runtime TypeError.